search

SporosDAO / sweat-token

Sweat Token code and resources - Sweat Equity Vault for DAOs
https://app.sporosdao.xyz
Apache License 2.0
18 stars 16 forks source link

Feat: dao formation #183

Closed ivelin closed 1 year ago

ivelin commented 1 year ago

Continued work on DAO Formation based on @0xMakka 's Draft PR #148

netlify[bot] commented 1 year ago

Deploy Preview for sporosdaoapp-dev ready!

Name Link
Latest commit 337d83dce786c07fbc3eff34f65fb5ee4479f224
Latest deploy log https://app.netlify.com/sites/sporosdaoapp-dev/deploys/639ccbba61bcfa0008b6079c
Deploy Preview https://deploy-preview-183--sporosdaoapp-dev.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

lipmaneth commented 1 year ago

screenshot

Our CTA on the new website is "Start Your Company." We should be consistent with our language since we're saying DAO here. Up to this point, we all agreed Company is the right word bc Sporos isn't just for 'DAOs' but we should decide if we want to say "DAO" and then be consistent everywhere.

Browser metadata ``` Path: / Browser: Chrome 107.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

screenshot

Content changes to marry up with figma https://www.figma.com/file/HjgPX0qjMYgvDjeliS4EwD/Sporos-DAO-App?node-id=637%3A87910&t=VagQAtEtSXEaKrgf-0

Browser metadata ``` Path: /dao/create/42161 Browser: Chrome 107.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fcreate%2F42161&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

recording

Fields aren't showing on the Name screen.

Browser metadata ``` Path: /dao/create/stepper/42161 Browser: Chrome 107.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fcreate%2Fstepper%2F42161&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

recording

Browser metadata ``` Path: /dao/create/stepper/42161 Browser: Chrome 107.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fcreate%2Fstepper%2F42161&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

recording

Can't see info inputted into fields. Also background is gray for founder area where should be white.

Browser metadata ``` Path: /dao/create/stepper/42161 Browser: Chrome 107.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fcreate%2Fstepper%2F42161&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

recording

If a user accidentally clicks "add founder" there's no way to delete a founder in order to continue with the flow. In the example shown here, I've added 4 other founders but I'm really the only founder. I now want to delete the others so I can move on. I'm now stuck.

Browser metadata ``` Path: /dao/create/stepper/42161 Browser: Chrome 107.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fcreate%2Fstepper%2F42161&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

recording

I'm able to input a ton of characters in the token symbol field. I believe the max supported by blockchain explorers is 11 but not 100% confident in that.

Browser metadata ``` Path: /dao/create/stepper/42161 Browser: Chrome 107.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fcreate%2Fstepper%2F42161&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

kleb-33 commented 1 year ago

image This is what I see when starting the create a LLC flow. Very different colours from lipmans screen. Much of the headings and text on right hand panel are unclear.

kleb-33 commented 1 year ago

image Unlike lipmans experience, the company name fields are all showing for me. The panel on the left is clear. Panel on right unclear as in the previous screen.

kleb-33 commented 1 year ago

image Founder fields not visible. They do appear when clicked on.

kleb-33 commented 1 year ago

image Adding a founder works aside from the visibility.

ivelin commented 1 year ago

Good report, Kleb. It shows that the custom theme was not prepared to handle dark mode. I will go through these inconsistencies and replace them with default MUI colors and icons.

As we've discussed before, that's one of the many details that need to be handled when building a custom theme. It's very resource intensive to get it right in all modes on all devices and all browsers. It is not an automatic switch from good looking Figma drawings to production ready code.

On Fri, Dec 9, 2022 at 3:16 AM kleb-33 @.***> wrote:

[image: image] https://user-images.githubusercontent.com/91540657/206667075-ef866a37-062f-4542-86f5-e3f220b1e6e3.png This is what I see when starting the create a LLC flow. Very different colours from lipmans screen. Much of the headings and text on right hand panel are unclear.

— Reply to this email directly, view it on GitHub https://github.com/SporosDAO/sweat-token/pull/183#issuecomment-1344050412, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARBUFO3QQ4MOD3MNGDOZTDWML2IBANCNFSM6AAAAAASRDDMKI . You are receiving this because you authored the thread.Message ID: @.***>

ivelin commented 1 year ago

OK, good catch. That is another example with custom theming. It's hard to get it to look good on all devices, modes and browsers. I will go through these and revert to default MUI options. The weird thing is that you seem to be using the same OS and browser that I am testing on and there is still inconsistency in theme color rendering.

On Thu, Dec 8, 2022 at 8:23 AM lipman @.***> wrote:

[image: recording] https://camo.githubusercontent.com/9a286416533e806aee0da08372583d0112c1c09f9418dd2920da5eb0c513fa8c/68747470733a2f2f6e65746c6966792d636f636f6f6e2e6e65746c6966792e6170702f2e6e65746c6966792f66756e6374696f6e732f66657463683f636f64653d33303726706174683d65794a7a6158526c58326c6b496a6f694e5468684e5451324e5751744d6d4a695a5330305a5449304c54686b4d4749745a57566c4d6a466d5a54426b4e475a69496977695a4756776247393558326c6b496a6f694e6a4d354d475a6a4d544131596a64684f5451774d4441355a44466959324a6949697769615751694f6949325a5749344e6a46684d6930334d5452684c54526d4f5459744f544a685a6931694d5451304d4449345a474a6b4f54416966513d3d Browser metadata

Path: /dao/create/stepper/42161

Browser: Chrome 107.0.0.0 on Mac OS 10.15.7

Viewport: 1966 x 1177 @2x

Language: en-US

Cookies: Enabled

Open in BrowserStack https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fcreate%2Fstepper%2F42161&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source

Open Deploy Preview https://deploy-preview-183--sporosdaoapp-dev.netlify.app/dao/create/stepper/42161 · Mark as Resolved https://app.netlify.com/cdp/resolve?deployID=6390fc105b7a940009d1bcbb&commentID=6391f352957917200ed891b2&resolution=resolved

— Reply to this email directly, view it on GitHub https://github.com/SporosDAO/sweat-token/pull/183#issuecomment-1342814818, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARBUFPFCW3EN7TGYPSMUWTWMHVN3ANCNFSM6AAAAAASRDDMKI . You are receiving this because you authored the thread.Message ID: @.***>

ivelin commented 1 year ago

Black font on the green button is automatically calculated by MUI in order to meet usability requirements. Forcing white will break one of the lighthouse tests for contrast or color blind differences. It could be many man weeks of effort to try to get a custom theme working properly. My focus will be on reasonable user experience with MUI defaults for MMP. If we want to launch something soon, a pixel perfect match of figma examples will have to come in a follow up version.

On Thu, Dec 8, 2022 at 8:13 AM lipman @.***> wrote:

[image: screenshot] https://camo.githubusercontent.com/5f91057f45d90766a84c45600284c8464369f3fea2e00b1b907b2612ef9f006b/68747470733a2f2f6e65746c6966792d636f636f6f6e2e6e65746c6966792e6170702f2e6e65746c6966792f66756e6374696f6e732f66657463683f636f64653d33303726706174683d65794a7a6158526c58326c6b496a6f694e5468684e5451324e5751744d6d4a695a5330305a5449304c54686b4d4749745a57566c4d6a466d5a54426b4e475a69496977695a4756776247393558326c6b496a6f694e6a4d354d475a6a4d544131596a64684f5451774d4441355a44466959324a6949697769615751694f6949355a6d4a6a4e7a4e6a4e7930324e545a6a4c5452694e6a6774596a4e6c4e79307a4e4459774d4451314f4746684e7a496966513d3d

Content changes to marry up with figma https://www.figma.com/file/HjgPX0qjMYgvDjeliS4EwD/Sporos-DAO-App?node-id=637%3A87910&t=VagQAtEtSXEaKrgf-0 Browser metadata

Path: /dao/create/42161

Browser: Chrome 107.0.0.0 on Mac OS 10.15.7

Viewport: 1966 x 1177 @2x

Language: en-US

Cookies: Enabled

Open in BrowserStack https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fcreate%2F42161&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source

Open Deploy Preview https://deploy-preview-183--sporosdaoapp-dev.netlify.app/dao/create/42161 · Mark as Resolved https://app.netlify.com/cdp/resolve?deployID=6390fc105b7a940009d1bcbb&commentID=6391f10e74f72b1dbf2786b9&resolution=resolved

— Reply to this email directly, view it on GitHub https://github.com/SporosDAO/sweat-token/pull/183#issuecomment-1342800245, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARBUFMP4DPUSQ7DQGZPV6TWMHUJTANCNFSM6AAAAAASRDDMKI . You are receiving this because you authored the thread.Message ID: @.***>

ivelin commented 1 year ago

recording

I'm able to input a ton of characters in the token symbol field. I believe the max supported by blockchain explorers is 11 but not 100% confident in that.

Browser metadata Open Deploy Preview · Mark as Resolved

Good catch. There is no restriction at the contract level, but it's a good practice to keep this short so it looks good in most front ends that expect a short ticker. I set the limit to 11.

ivelin commented 1 year ago

screenshot

Our CTA on the new website is "Start Your Company." We should be consistent with our language since we're saying DAO here. Up to this point, we all agreed Company is the right word bc Sporos isn't just for 'DAOs' but we should decide if we want to say "DAO" and then be consistent everywhere.

Browser metadata Open Deploy Preview · Mark as Resolved

OK. Drop here a screenshot of the latest landing page design with the exact language.

lipmaneth commented 1 year ago

screenshot

Dark mode has discoloring. @ivelin in Netbee's designs we did not include a dark mode to keep things simple for v1. Idk how complicated it is to create a light mode and dark mode but imo just doing one for v1 is sufficient.

Browser metadata ``` Path: /dao/chain/42161/create/ Browser: Chrome 107.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fchain%2F42161%2Fcreate%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

screenshot

Button font color should be white

Browser metadata ``` Path: /dao/chain/42161/create/stepper/ Browser: Chrome 107.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fchain%2F42161%2Fcreate%2Fstepper%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

screenshot

Can't see founder fields. Side bar copy and background is discolored.

Browser metadata ``` Path: /dao/chain/42161/create/stepper/ Browser: Chrome 107.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fchain%2F42161%2Fcreate%2Fstepper%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

screenshot

Can't see settings fields. Side bar with content discolored.

Browser metadata ``` Path: /dao/chain/42161/create/stepper/ Browser: Chrome 107.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fchain%2F42161%2Fcreate%2Fstepper%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

recording

unable to see many of the fields and copy from this screen.

Browser metadata ``` Path: /dao/chain/42161/create/stepper/ Browser: Chrome 107.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fchain%2F42161%2Fcreate%2Fstepper%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

recording

Will we not charge at launch? I see we're waiving the fee. Btw Ignore the ending. I rejected the txn which is why you see the error message.

Browser metadata ``` Path: /dao/chain/42161/create/stepper/ Browser: Chrome 107.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fchain%2F42161%2Fcreate%2Fstepper%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

recording

clicking the menu options doesn't do anything

Browser metadata ``` Path: /dao/chain/42161/create/stepper/ Browser: Chrome 107.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fchain%2F42161%2Fcreate%2Fstepper%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

recording

I mentioned dark/light mode in a previous comment but how do you switch back and forth between the two? I don't see that option.

Browser metadata ``` Path: /dao/chain/5/create/ Browser: Chrome 107.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fchain%2F5%2Fcreate%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

screenshot

This top bar was confusing. Almost looks like a search bar but when I clicked the X I saw it took me out of this screen back to the homepage.

Browser metadata ``` Path: /dao/chain/5/create/ Browser: Chrome 107.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fchain%2F5%2Fcreate%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=107.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

recording

First screen still has formatting issues on the right side of the page. Also at the top above "Launch Your Company in Minutes"

Browser metadata ``` Path: /dao/chain/42161/create/ Browser: Chrome 108.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fchain%2F42161%2Fcreate%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=108.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

recording

Browser metadata ``` Path: /dao/chain/42161/create/stepper/ Browser: Chrome 108.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fchain%2F42161%2Fcreate%2Fstepper%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=108.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

recording

Nice! The Founder fields are legible now! See formatting issues with the right side and top of the page. Not sure if the menu options should be clickable but they don't appear to be.

Browser metadata ``` Path: /dao/chain/42161/create/stepper/ Browser: Chrome 108.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fchain%2F42161%2Fcreate%2Fstepper%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=108.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

recording

Nice! Settings fields are visible and look great. Right side is still not formatted properly.

Browser metadata ``` Path: /dao/chain/42161/create/stepper/ Browser: Chrome 108.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fchain%2F42161%2Fcreate%2Fstepper%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=108.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

recording

Looking good! May consider changing the subheader I've highlighted to a different color bc it's kind of hard to read. Right side of the screen is not formatted properly.

Browser metadata ``` Path: /dao/chain/42161/create/stepper/ Browser: Chrome 108.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fchain%2F42161%2Fcreate%2Fstepper%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=108.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

lipmaneth commented 1 year ago

screenshot

Looking good! See right side of the screen again.

Browser metadata ``` Path: /dao/chain/42161/create/stepper/ Browser: Chrome 108.0.0.0 on Mac OS 10.15.7 Viewport: 1966 x 1177 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-183--sporosdaoapp-dev.netlify.app%2Fdao%2Fchain%2F42161%2Fcreate%2Fstepper%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=108.0&resolution=1966x1177&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

EdgeCaser commented 1 year ago

Also getting the invisible fields bug . This is on a WIndows 11 machine using Brave image

ivelin commented 1 year ago

recording

Nice! The Founder fields are legible now! See formatting issues with the right side and top of the page. Not sure if the menu options should be clickable but they don't appear to be.

Browser metadata Open Deploy Preview · Mark as Resolved

Good feedback.

Navigation tabs are not supposed to be clickable. Just show progress. I did make changes yesterday to make sure the mouse pointer does not indicate clickable items. Also added checkmarks next to tabs that have been completed. If that is still confusing, we can switch to a more standard MUI stepper.

kleb-33 commented 1 year ago

image

On settings page, field for Voting Period is set to hours. This is not adjustable. If I want to set a voting period to be < 1 hr (e.g 15 mins) the warning message appears telling me 'Voting period has to be a positive number'. 0.25 hrs is a positive number so either:

  1. Warning message needs to be adjusted to say that voting period has to be minimum 1 hr
  2. We give users the option of setting voting period to less than one hour
  3. We give users the option of setting voting period in minutes instead of hours

3 is the best option from user perspective but probably the most work. 1 is the simplest fix in short term.

kleb-33 commented 1 year ago

image The Note! section on the right hand panel is not relevant anymore. We had this in the flow when there was no Settings page. As users are inputting their own settings, we can remove this paragraph from the Confirmation page.

kleb-33 commented 1 year ago

image

Panel on right should read: ' Can I launch my company with more than one founder? Yes. You can add up to 5 founders when you launch your company.'

kleb-33 commented 1 year ago

image Minor point but can we remove the capital letters from the words 'Review All Settings' on right-hand panel. Should read: 'Carefully review all settings!'

ivelin commented 1 year ago

recording

I mentioned dark/light mode in a previous comment but how do you switch back and forth between the two? I don't see that option.

Browser metadata Open Deploy Preview · Mark as Resolved

Currently the app picks up dynamically the OS mode. Usually light during daytime and dark at night. We can add an explicit switch if users ask for it.

ivelin commented 1 year ago

image

On settings page, field for Voting Period is set to hours. This is not adjustable. If I want to set a voting period to be < 1 hr (e.g 15 mins) the warning message appears telling me 'Voting period has to be a positive number'. 0.25 hrs is a positive number so either:

  1. Warning message needs to be adjusted to say that voting period has to be minimum 1 hr
  2. We give users the option of setting voting period to less than one hour
  3. We give users the option of setting voting period in minutes instead of hours

3 is the best option from user perspective but probably the most work. 1 is the simplest fix in short term.

UPDATE: Implemented #2. Fractional number of hours is allowed as input.

OK, will do 1 for now and see how users react.