search

SpoticordMusic / spoticord

The official Spoticord Music Discord bot
https://spoticord.com/
GNU Affero General Public License v3.0
47 stars 7 forks source link

[BUG] Hardcoded url in join voice error embed #24

Closed spectrapulse closed 1 year ago

spectrapulse commented 1 year ago

Describe the bug Self-Hosted Spoticord shows the wrong account linking URL when running into an error while joining the voice channel with no accounts linked.

To Reproduce Steps to reproduce the behavior:

  1. Unlink your Spotify and/or Discord account from self-hosted Spoticord.
  2. Ask the bot to join your current voice channel.

Expected behavior Bot would say where to link user's account with the correct URL.

Screenshots Image showing the incorrect link in embed

Additional context The instances in the source where this happens with this specific issue are here: https://github.com/SpoticordMusic/spoticord/blob/4d12d381861728446c11cea793ecb5368228c4a1/src/bot/commands/music/join.rs#L244 https://github.com/SpoticordMusic/spoticord/blob/4d12d381861728446c11cea793ecb5368228c4a1/src/bot/commands/music/join.rs#L258 I would fix it myself and make a pr except I don't have experience with Rust so it's very possible that I would come up with an undesirable solution :p

DaXcess commented 1 year ago

Patch is ready on the dev branch, will keep issue open until it's merged into main on the next version