search

SpykerNZ / one-pace-for-plex

This project helps adapt One Pace to a format plex can read.
86 stars 9 forks source link

Renaming conflict S35 1080p #62

Open Lueron opened 3 months ago

Lueron commented 3 months ago

I noticed while setting this up myself that the renamer had issues with Season 35, where it attempted to rename all my regular anime episodes from 1072 to 1085 to the same 1080 episode causing it to error and not continue

This was due to the release I downloaded including the quality in the title i.e [Release] One piece - 1071 [1080p][HEVC 10bit x265] etc...

Was an easy fix on my end to remove the quality from the filenames manually but thought it might be of interest to you in case others come with similar issues as I noticed in this event the rename.exe didn't output anything it just closed so I used the python script to monitor

Huge thanks for the project it is extremely valuable

SpykerNZ commented 3 months ago

probably needs an update to the regex pattern to ensure we don't hit these cases.

Were these the original files downloaded from the One Pace website? can you list all the title names that failed?

Lueron commented 3 months ago

probably needs an update to the regex pattern to ensure we don't hit these cases.

Were these the original files downloaded from the One Pace website? can you list all the title names that failed?

It was specifically the non one pace episodes to fill the gap where one pace has not finished yet at the end of Wano, so will be inconsistent user to user as to where they get these episodes from, but including the quality is pretty standard in most releases so I imagine it'd be a reasonably common problem.

It renamed episode 1072 to 1080, thinking that the 1080p in the title meant episode 1080, then it tried to rename 1073 to the same 1080 title, errored and then closed, therefore not renaming any episodes after there, or any of the Egghead One Pace episodes

Here are the exact titles I had that caused the issue, image

Also an unrelated minor error i've discovered since the above: on line 40 of tvshow.nfo in at /one-pace-for-plex/One Pace/tvshow.nfo , both Marineford and The Adventures of Strawhats are titled Season 25, making the ones below other than Egghead also off by 1