search

SrRapero720 / waterframes

Mod which let you see pictures in-game amen
24 stars 13 forks source link

Crashing after latest update #104

Closed andriihorpenko closed 3 months ago

andriihorpenko commented 3 months ago

Simply opening any TV leads to a crash of a dedicated server. crash-2024-08-19_16.55.19-server.txt

andriihorpenko commented 3 months ago

By the way, (Neo)Forge discourages usage of @OnlyIn annotation, as it is not meant to be used by modders. https://github.com/SrRapero720/waterframes/blob/de4816a31e4414ed779af0e25fbff6ac44c3cc1a/src/main/java/me/srrapero720/waterframes/common/block/entity/DisplayTile.java#L43 This basically strips that line from the compiled code, which leads to the crash above.

Laurentzius commented 3 months ago

same problem on singleplayer all ok but crashes on server

SrRapero720 commented 3 months ago

Issue has been fixed.

SrRapero720 commented 3 months ago

By the way, (Neo)Forge discourages usage of @OnlyIn annotation, as it is not meant to be used by modders.

I am not sure what are you trying to tell me, if i use it was for a very good reason :P anyway, issue has nothing to do about the annotation usage, was the creativecore GuiLayer thing.