search

StackStorm / hubot-stackstorm

Hubot plugin for integration with StackStorm event-driven infrastructure automation platform.
Apache License 2.0
49 stars 39 forks source link

Update node checks #218

Closed amanda11 closed 3 years ago

amanda11 commented 3 years ago

Update to check against node > 12

amanda11 commented 3 years ago

@blag - thanks for review. Shorted test matrix, am I ok to leave hubot-stackstorm version as before as not changed anything in the actual package?

blag commented 3 years ago

For this change, that's correct - we do not need to bump and push a new version to NPM, as this is just testing changes.

If we update dependencies, like all of @dependabot's PRs, we should bump the version. But we can "batch" those together with respect to versioning - in other words, we can merge in multiple dependency updates before we bump the version and push it to NPM.