Closed blag closed 5 years ago
Merging #17 into master will increase coverage by
0.3%
. The diff coverage is99.3%
.
@@ Coverage Diff @@
## master #17 +/- ##
=========================================
+ Coverage 98.27% 98.57% +0.3%
=========================================
Files 11 12 +1
Lines 463 561 +98
=========================================
+ Hits 455 553 +98
Misses 8 8
Impacted Files | Coverage Δ | |
---|---|---|
orquestaconvert/expressions/mixed.py | 100% <100%> (ø) |
|
orquestaconvert/expressions/yaql.py | 100% <100%> (ø) |
:arrow_up: |
orquestaconvert/expressions/jinja.py | 100% <100%> (ø) |
:arrow_up: |
orquestaconvert/expressions/base.py | 100% <100%> (ø) |
:arrow_up: |
orquestaconvert/workflows/base.py | 100% <100%> (ø) |
:arrow_up: |
orquestaconvert/expressions/__init__.py | 100% <100%> (ø) |
:arrow_up: |
orquestaconvert/pack_client.py | 92.47% <75%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3423e71...bc819f4. Read the comment docs.
This PR adds support for converting Mistral's
with-items
andconcurrency
task attributes.See this page of the Mistral docs for some examples.
should produce the following in orquesta
There is quite a bit of code churn in the pack tests, and it was a little difficult for me to extract the churn from the additional tests, so I recommend looking at the end results than the commit diff for that. I added quite a few additional fixtures for the integration tests for the pack client.
Interpreting and converting the
with-items
list correctly requires that all items in the list utilize the same expression format (eg: either all static/Jinja expressions or all static/YAQL expressions), however, it does not validate that.Also, this does support syntax like:
and converts it to:
because we have some workflows that utilize that. I'm not 100% sure it's valid Mistral syntax, but since Mistral does seem to run it just fine I wanted to convert it to a more proper format that Orquesta can run just fine as well.