Closed blag closed 5 years ago
Merging #19 into master will increase coverage by
0.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 98.57% 98.59% +0.01%
==========================================
Files 12 12
Lines 561 568 +7
==========================================
+ Hits 553 560 +7
Misses 8 8
Impacted Files | Coverage Δ | |
---|---|---|
orquestaconvert/workflows/base.py | 100% <100%> (ø) |
:arrow_up: |
orquestaconvert/expressions/__init__.py | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a39bd93...8212130. Read the comment docs.
Resolved. I couldn't use Jinja in when: <% succeeded() %>
since the script uses YAQL for other fixtures, but the Jinja fixtures now use Jinja as much as they can.
LGTM, thanks!
This PR corrects how
concurrency
attributes are converted by converting them as expressions...if they are expressions. If they are not expressions they are not touched.So this snippet:
would get (incompletely) converted to this:
this PR adds support so the
concurrency
attribute is treated like an expression and converted correctly:I added unit tests for cases where
concurrency
is an integer, a string that represents an integer, and YAQL and Jinja expressions, as well as end-to-end test files for the same.I also made a single-line change to
orquestaconvert/expressions/__init__.py
, to make it slightly more bulletproof: it now tries to convert expressions to strings before passing them to Orquesta for expression type analysis. This should also make it raise a cleaner error message than the previous "TypeError: expected string or buffer" from there
module, and it better indicates the problem and a potential fix.