search

Standard-Labs / real-intent

Python SDK and abstracted interface for BigDBM's API.
0 stars 0 forks source link

Agent notes in kvCORE integration #97

Closed preritdas closed 1 month ago

preritdas commented 1 month ago

Closes #94.

Populate kvCORE user's Agent Notes (for each lead) with stringified key values of curated PII attributes.

Curated PII attrs are hardcoded. Uses new ._agent_notes method to allow the entire class to be subclasses for eventual per-lead insights.

Eventually, call super()._agent_notes(...) before appending AI insight to the end, similar to the subclassing behavior from the original FUB integration to the AI one.

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes introduce a new private method _agent_notes in the kvCORE module, which generates custom agent notes for leads based on the pii_md5 object. This method formats household income and net worth attributes into a string. The _email_body method is updated to include these agent notes in the email sent to agents. Additionally, a test is added to ensure the presence of "Agent Notes" in the email body.

Changes

Files Change Summary
real_intent/deliver/kvcore/__init__.py Added _agent_notes method to generate agent notes and modified _email_body to include them.
tests/test_kvcore.py Added assertion in test_kvcore_email_body to check for "Agent Notes" in the email body.

Assessment against linked issues

Objective Addressed Explanation
Custom fields for agent notes (Issue #94) ✅
Multi-line comments for agent notes (Issue #94) ❌ No implementation for multi-line comments.

Possibly related PRs

Poem

🐇 In the land of kvCORE, notes now take flight,
With agent insights shining bright.
Income and worth, all neatly aligned,
In emails they dance, perfectly designed.
Hopping along, we celebrate this feat,
For better leads, our work is complete! 🌟

Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

Early access features: enabled