Closed vishnuravi closed 11 months ago
@Supereg any idea why we are getting the discouraged_optional_collection
error here? Those files were not touched and seemed to have passed before?
Merging #33 (8051627) into main (5bbeed7) will decrease coverage by
76.41%
. The diff coverage is0.00%
.
@Supereg any idea why we are getting the
discouraged_optional_collection
error here? Those files were not touched and seemed to have passed before?
Not sure why they pop up now. But feel free to add some //swiftlint:disable:this discouraged_optional_collection
to the lines.
@Supereg any idea why we are getting the
discouraged_optional_collection
error here? Those files were not touched and seemed to have passed before?Not sure why they pop up now. But feel free to add some
//swiftlint:disable:this discouraged_optional_collection
to the lines.
Thanks. I added this and then I got a line length - sometimes you just can't win!!
@Supereg any idea why we are getting the
discouraged_optional_collection
error here? Those files were not touched and seemed to have passed before?Not sure why they pop up now. But feel free to add some
//swiftlint:disable:this discouraged_optional_collection
to the lines.Thanks. I added this and then I got a line length - sometimes you just can't win!!
There is also a swiftlint:disable:previous ...
which might be helpful here π
@vishnuravi Following up on our discussion today: I addressed most of the issues with the localization files and only needed to translate a few very limited elements and added comments for the rest.
Looking forward to getting the PR finished and feel free to merge it once all the conversations are resolved π
fyi, I'm currently rebasing this PR and taking care of it getting it merged if that is alright for you @vishnuravi π
fyi, I'm currently rebasing this PR and taking care of it getting it merged if that is alright for you @vishnuravi π
That sounds great, thank you @Supereg!
Use string catalogues and fix non-localized strings
:gear: Release Notes
Migrates to use of string catalogues for localization and fixes a string that is not being drawn from the localization files.
:pencil: Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: