Use string catalogues and fix non-localized strings

[vishnuravi]

Use string catalogues and fix non-localized strings

:gear: Release Notes

Migrates to use of string catalogues for localization and fixes a string that is not being drawn from the localization files.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

• [X] I agree to follow the Code of Conduct and Contributing Guidelines.

[vishnuravi]

@Supereg any idea why we are getting the discouraged_optional_collection error here? Those files were not touched and seemed to have passed before?

[codecov[bot]]

Codecov Report

Merging #33 (8051627) into main (5bbeed7) will decrease coverage by 76.41%. The diff coverage is 0.00%.

Additional details and impacted files

[](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #33 +/- ## ========================================== - Coverage 76.42% 0.00% -76.41% ========================================== Files 114 114 Lines 3952 3964 +12 ========================================== - Hits 3020 0 -3020 - Misses 932 3964 +3032 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [Sources/SpeziAccount/AccountSetup.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNldHVwLnN3aWZ0) | `0.00% <0.00%> (-72.50%)` | :arrow_down: | | [...s/SpeziAccount/Mock/MockSimpleAccountService.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvTW9jay9Nb2NrU2ltcGxlQWNjb3VudFNlcnZpY2Uuc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [...count/Views/AccountSetup/ExistingAccountView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvQWNjb3VudFNldHVwL0V4aXN0aW5nQWNjb3VudFZpZXcuc3dpZnQ=) | `0.00% <0.00%> (-67.85%)` | :arrow_down: | | [...s/SpeziAccount/Views/UserIdPasswordResetView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvVXNlcklkUGFzc3dvcmRSZXNldFZpZXcuc3dpZnQ=) | `0.00% <0.00%> (-85.29%)` | :arrow_down: | | [.../SpeziAccount/AccountValue/Keys/AccountIdKey.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFZhbHVlL0tleXMvQWNjb3VudElkS2V5LnN3aWZ0) | `0.00% <0.00%> (-21.42%)` | :arrow_down: | | [...count/ViewModel/AccountOverviewFormViewModel.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld01vZGVsL0FjY291bnRPdmVydmlld0Zvcm1WaWV3TW9kZWwuc3dpZnQ=) | `0.00% <0.00%> (-93.45%)` | :arrow_down: | | [...SpeziAccount/Views/DataDisplay/SimpleTextRow.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvRGF0YURpc3BsYXkvU2ltcGxlVGV4dFJvdy5zd2lmdA==) | `0.00% <0.00%> (-72.22%)` | :arrow_down: | | [...iews/AccountOverview/AccountOverviewSections.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvQWNjb3VudE92ZXJ2aWV3L0FjY291bnRPdmVydmlld1NlY3Rpb25zLnN3aWZ0) | `0.00% <0.00%> (-89.08%)` | :arrow_down: | | [Sources/SpeziAccount/AccountOverview.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudE92ZXJ2aWV3LnN3aWZ0) | `0.00% <0.00%> (-56.36%)` | :arrow_down: | | [...ment/AccountServiceConfiguration+Environment.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvRW52aXJvbm1lbnQvQWNjb3VudFNlcnZpY2VDb25maWd1cmF0aW9uK0Vudmlyb25tZW50LnN3aWZ0) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | ... and [1 more](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/33?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | | ... and [94 files with indirect coverage changes](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/33/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/33?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/33?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [5bbeed7...8051627](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/33?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).

[Supereg]

@Supereg any idea why we are getting the discouraged_optional_collection error here? Those files were not touched and seemed to have passed before?

Not sure why they pop up now. But feel free to add some //swiftlint:disable:this discouraged_optional_collection to the lines.

[vishnuravi]

@Supereg any idea why we are getting the discouraged_optional_collection error here? Those files were not touched and seemed to have passed before?

Not sure why they pop up now. But feel free to add some //swiftlint:disable:this discouraged_optional_collection to the lines.

Thanks. I added this and then I got a line length - sometimes you just can't win!!

[Supereg]

@Supereg any idea why we are getting the discouraged_optional_collection error here? Those files were not touched and seemed to have passed before?

Not sure why they pop up now. But feel free to add some //swiftlint:disable:this discouraged_optional_collection to the lines.

Thanks. I added this and then I got a line length - sometimes you just can't win!!

There is also a swiftlint:disable:previous ... which might be helpful here 😅

[PSchmiedmayer]

@vishnuravi Following up on our discussion today: I addressed most of the issues with the localization files and only needed to translate a few very limited elements and added comments for the rest.

Looking forward to getting the PR finished and feel free to merge it once all the conversations are resolved 👍

[Supereg]

fyi, I'm currently rebasing this PR and taking care of it getting it merged if that is alright for you @vishnuravi 👍

[vishnuravi]

fyi, I'm currently rebasing this PR and taking care of it getting it merged if that is alright for you @vishnuravi 👍

That sounds great, thank you @Supereg!