Closed pauljohanneskraft closed 3 weeks ago
codecov[bot]
commented
2 months ago Attention: Patch coverage is 74.71264% with 44 lines in your changes missing coverage. Please review.
Project coverage is 83.23%. Comparing base (
7ffb73d) to head (f082fa8). Report is 1 commits behind head on main.
pauljohanneskraft
commented
2 months ago I reverted the changes that are needed in ENGAGE-HF and will open a different PR instead, since this might still be a nice addition, but actually isn't needed urgently anymore.
Feel free to keep this open / ask for adaptions though!
Supereg
commented
3 weeks ago To save you some context switches and time, I went forward and quickly incorporated the changes I had in my comments and rebased onto the latest changes from main. I noticed that in your implementation the loadingExistingAccount was never actually set anymore. I fixed that and merged that state with the isCompletingSetup state you introduced. I used this step to also polish the AccountSetupState implementation a bit and fully exposed it, replacing the previous underscore implementation.
Hope that works and feel free to merge the PR if you are happy with the changes. We can release these as 2.1.0 then 👍
PSchmiedmayer
commented
3 weeks ago Amazing; thank you @Supereg!
Feel free to merge the PR if it looks good to you @pauljohanneskraft 🚀
Allow AccountSetup to be created with async throwing function to handle completeness of the account setup
:recycle: Current situation & Problem
When an account setup is successful, one may want to run additional code that is async and throwing to finish the account setup completely.
Specifically in ENGAGE-HF, we need to call a Firebase function when a new account has been created before the account can actually be used.
:gear: Release Notes
setupCompleteparameter inAccountSetupto be async-throwing.:books: Documentation
Please ensure that you properly document any additions in conformance to Spezi Documentation Guide. You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.
:white_check_mark: Testing
Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested. This section describes important information about the tests and why some elements might not be testable.
:pencil: Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: