Star2Billing / django-country-dialcode

Django reusable application to manage Dial code of Countries
www.star2billing.com
Other
14 stars 17 forks source link

Please add Taiwan as a different Country #9

Closed raun closed 6 years ago

raun commented 7 years ago

Our company uses django-country-dailcode(https://pypi.python.org/pypi/django-country-dialcode/0.6.3). It seems the last release was in 2015.

One of customer pointed out that Taiwan is different than Taiwan(Province of China). Can you add a new country Taiwan into the list of countries.

Simply upgrading the package would solve the problem for us.

Let us know if you need help. I would be interested to contribute.

areski commented 7 years ago

It seems fine according to https://en.wikipedia.org/wiki/ISO_3166-1_alpha-3 You can check the fixture here and see https://raw.githubusercontent.com/Star2Billing/django-country-dialcode/develop/country_dialcode/fixtures/country_dialcode.json

    "fields": {
        "countrycode": "TWN",
        "countryname": "Taiwan, Province Of China",
        "countryprefix": 886,
    "iso2": "TW"
    },

Send a PR if you need to make some changes.

On Tue, Apr 4, 2017 at 2:14 PM, Anshul notifications@github.com wrote:

Our company uses django-country-dailcode(https: //pypi.python.org/pypi/django-country-dialcode/0.6.3). It seems the last release was in 2015.

One of customer pointed out that Taiwan is different than Taiwan(Province of China). And I could see you have added a new country Taiwan.

Simply upgrading the package would solve the problem for us.

Let us know if you need help. I would be interested to contribute.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Star2Billing/django-country-dialcode/issues/9, or mute the thread https://github.com/notifications/unsubscribe-auth/AADQz0J82uPqi_9ANPzCCtJjhnFQVQqYks5rsjQrgaJpZM4MyxZW .

-- Kind regards, /Areski


Arezqui Belaid Founder at Star2Billing (www.star2billing.com) & Newfies-Dialer (www.newfies-dialer.org)

Tel: +34650784355 Twitter: http://twitter.com/areskib LinkedIn: http://www.linkedin.com/in/areski