search

StarRezDevTeam / Serilog.Sinks.AzureWebJobsTraceWriter

Serilog Azure WebJobs/Functions TraceWriter Sink
MIT License
19 stars 4 forks source link

Updated to .net Standard 2 and Microsoft.Azure.WebJobs 3.0.0-rc1 #10

Open ghost opened 6 years ago

ghost commented 6 years ago

Updated to .net Standard 2 and Microsoft.Azure.WebJobs 3.0.0-rc1

vludax commented 6 years ago

Hi @Peppers911, thanks for the PR. I assume it would address #6. As mentioned in that issue, we stuck to .NET Framework instead of converting the library to .NET Standard as queue-triggered functions did not appear to fire when we converted them to .NET Standard. Does that issue not occur for you, and do queue-triggered functions work just fine?

ghost commented 6 years ago

I think you forgot to register your trigger?

Below the table in: https://docs.microsoft.com/en-us/azure/azure-functions/functions-triggers-bindings#supported-bindings

In 2.x, all bindings except HTTP, Timer, and Azure Storage must be registered. See Register binding extensions.

vludax commented 6 years ago

Hmm, yes, that is possible. It's been a while :) We'll test this out soon, likely next week, and will merge ASAP.

jansoren commented 6 years ago

Finished soon? 🙏

vludax commented 6 years ago

Sorry, we haven't had a chance to look at this yet. We definitely will check it out in the near future and will respond here. Just can't say a particular date yet.

fplanjer commented 5 years ago

What is the status of this PR? I'd love to see NetStandard support for this.