StarbeamOne / home

Basic central repository for issue-tracking and documentation (wiki)
MIT License
2 stars 0 forks source link

Capacity not maintained on inventory price change #117

Closed ujmappa closed 10 months ago

ujmappa commented 11 months ago

I've tried to change the price for one of my items in inventory, but after raising it, the capacity was not decreased for appropriate market

Mike-E-angelo commented 11 months ago

Whoa, that is a bug. I will look into this. Thank you for reporting this. 👍

Mike-E-angelo commented 11 months ago

Boo, I am not sure what I was thinking here. 🤦‍♂️ My thought was that capacity is consumed at the time of publishing and is static. If you lower capacity and sell you get the initially utilized capacity back. However, without limits, someone could indeed publish at a lower price and then max out the price after the fact, effectively bypassing capacity limits by using market minimums.

Two options:

What do you think @ujmappa should I take the easy or difficult route? 🤔

ujmappa commented 11 months ago

Almost every system allows to change the price. I usually prefer simple things, but here your simple solution is too restrictive and I don't think the "complex" solution is that complex if it can be done within 2 days. So I would choose option B.

Mike-E-angelo commented 11 months ago

I'm apt to agree with you, it's not that complex but everything seems that way from the outset. 😁 I am also balancing the schedule for Beta III which is already pretty tight, so that's my primary concern. I'll see if I can get this done by EOD. 👍

Mike-E-angelo commented 10 months ago

Alright @ujmappa this is now in staging for your review: https://staging.starbeam.one

If it looks OK to you I will push it to production 👍

ujmappa commented 10 months ago

It is okay, one glitch is when I try to raise the price above capacity limit, it resets the editfield to 0 flares, and then all the handling there gets messy, cannot set it to 1.5 - Instead of resetting just keep it on the maxvalue.

Mike-E-angelo commented 10 months ago

Whoops! Thank you for that. I will investigate now.

Mike-E-angelo commented 10 months ago

Please try now. 👍

ujmappa commented 10 months ago

It's okay now, it can go to prod

Mike-E-angelo commented 10 months ago

Done. Thank you again for all your valuable feedback!