Start9Labs / bitcoind-startos

wrapper for building bitcoind.s9pk
Other
12 stars 18 forks source link

[bug]: Fix bitcoind manager spamming stderr when bitcoind is not available #32

Open bbqchef opened 2 years ago

bbqchef commented 2 years ago

Prerequisites

EmbassyOS Version

0.3.0

Device

Laptop/Desktop

Device OS

Windows

Device OS Version

Windows 10

Browser

Firefox

Browser Version

95.0

Current Behavior

EOS Cant clear notification

Expected Behavior

Either 1) Notification text only shows once 2) Notification manages to inform user the error occurred multiple times.

Steps to Reproduce

I don't know what caused bitcoin core to crash or how to trigger notifications on demand.

Anything else?

No response

chrisguida commented 2 years ago

I'm not sure I understand. Is the problem that you want to receive a notification every time bitcoind crashes? We've debounced notifications specifically to avoid the user getting spammed with notifications if, for instance, bitcoind is an a crash loop.

See this issue for more details: https://github.com/Start9Labs/embassy-os/issues/576

bbqchef commented 2 years ago

Agreed that raising a notification at every crash would risk overcrowding the notifications. Seeing the same sentence repeated in the notification, I thought it was a bug. From your comment I gather this is a design choice, so not a bug.

chrisguida commented 2 years ago

Are you ok with this as a design choice? We don't want to confuse people.

dr-bonez commented 2 years ago

@chrisguida the service crash notification only contains stderr from a single run of the application. The error message shown contains repeat error messages coming from a single instance of bitcoin. It may be worth looking into being a little more careful about what gets logged to stderr.

ProofOfKeags commented 2 years ago

This ticket needs to be moved to https://github.com/Start9Labs/bitcoind-wrapper