Souheil-Yazji
commented
2 years ago The package-lock.json file causing the issue is in the frontend directory. Resolution attempts (EDIT: this is not the correct approach, see comment in closed PR):
- delete and recreate the package-lock.json using
npm install --package-lock-only --legacy-peer-deps. When building the docker image locally, the following error is encountered:
Step 11/22 : RUN npm run build
---> Running in 722a620a9744
> pipelines-frontend@0.1.0 prebuild /src
> npm run build:tailwind
> pipelines-frontend@0.1.0 build:tailwind /src
> npx tailwindcss build -i src/tailwind.css -o src/build/tailwind.output.css
Done in 817ms.
> pipelines-frontend@0.1.0 build /src
> npm run lint && EXTEND_ESLINT=true react-scripts build
> pipelines-frontend@0.1.0 lint /src
> eslint --ext js,ts,tsx src
/src/src/pages/Compare.tsx
28:10 warning 'TFunction' is defined but never used @typescript-eslint/no-unused-vars
29:10 warning 'useTranslation' is defined but never used @typescript-eslint/no-unused-vars
/src/src/pages/NewRun.tsx
101:11 warning 'NewRunProps' is defined but never used @typescript-eslint/no-unused-vars
✖ 3 problems (0 errors, 3 warnings)
Creating an optimized production build...
(node:95) [DEP_WEBPACK_COMPILATION_NORMAL_MODULE_LOADER_HOOK] DeprecationWarning: Compilation.hooks.normalModuleLoader was moved to NormalModule.getCompilationHooks(compilation).loader
(Use `node --trace-deprecation ...` to show where the warning was created)
Failed to compile.
Attempted import error: 'GettingStarted' is not exported from '../pages/GettingStarted' (imported as 'GettingStarted').
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! pipelines-frontend@0.1.0 build: `npm run lint && EXTEND_ESLINT=true react-scripts build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the pipelines-frontend@0.1.0 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /root/.npm/_logs/2022-09-26T12_01_49_193Z-debug.log
The command '/bin/sh -c npm run build' returned a non-zero code: 1
- Use the upstream package-lock/package.json combo
Creating an optimized production build... (node:73) [DEP_WEBPACK_COMPILATION_NORMAL_MODULE_LOADER_HOOK] DeprecationWarning: Compilation.hooks.normalModuleLoader was moved to NormalModule.getCompilationHooks(compilation).loader (Use `node --trace-deprecation ...` to show where the warning was created) Failed to compile.
Attempted import error: 'GettingStarted' is not exported from '../pages/GettingStarted' (imported as 'GettingStarted').
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! pipelines-frontend@0.1.0 build: npm run lint && EXTEND_ESLINT=true react-scripts build
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the pipelines-frontend@0.1.0 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in: npm ERR! /root/.npm/_logs/2022-09-26T12_20_31_820Z-debug.log The command '/bin/sh -c npm run build' returned a non-zero code: 1
As a sanity check, building the upstream repo passes this point but fails on step 13:Step 13/22 : RUN ./scripts/yarn-licenses.sh ---> Running in 8d89242fc6a6 /bin/sh: 1: ./scripts/yarn-licenses.sh: not found The command '/bin/sh -c ./scripts/yarn-licenses.sh' returned a non-zero code: 127
https://github.com/StatCan/kubeflow-pipelines/pull/47
Issue
Cause
Build fails due to what appears to be a mismatch between package.json and package-log.json. This is most-likely due to the rebase/merge modifying the package-lock.json file, which should only be modified using npm install
Full logs here: https://github.com/StatCan/kubeflow-pipelines/actions/runs/3092502404/jobs/5003841845#step:4:99