Closed domichel closed 1 year ago
This looks like it is failing to build the LV2's properly. I believe I know what the issue is, but would like to confirm that the failure is for LV2 build only. Could you build LV2s only with:
cmake -DBuildRakarrackPlus=OFF ..
Also try building Rakarrack-plus only with:
cmake -DBuildLV2Plugins-OFF ..
If I am correct, Rakarrack-plus should build and the LV2s only should fail.
Thanks.
Thanks,
I get the same error with both of them. I try with:
cmake -DLV2_INSTALL_DIR:PATH=lib64/lv2/RakarrackPlus.lv2 ..
because on gentoo amd64, all lv2 plugins are into /usr/lib64/lv2, but get the same error.
Also:
$ cat /usr/lib64/pkgconfig/lv2.pc
prefix=/usr
includedir=${prefix}/include
lv2dir=/usr/lib64/lv2
plugindir=/usr/lib64/lv2
Name: LV2
Description: Plugin standard for audio systems
Version: 1.18.10
Cflags: -I${includedir}
I just pushed a commit in the wip branch. Try rebuilding the wip branch with a clean build directory. The LV2 install directory should not matter.
With cmake ..
, I get a similar error:
[ 29%] Linking CXX shared library rakarrack-plus-lv2.so
[ 29%] Built target rakarrack-plus-lv2
[ 29%] Building CXX object src/CMakeFiles/rakarrack-plus.dir/Config_fltk.C.o
Dans le fichier inclus depuis /home/dom/softs/Musique/rakarrack-plus/src/Config_fltk.C:29:
/home/dom/softs/Musique/rakarrack-plus/src/global.h:48:10: erreur fatale: FL/Fl_Tiled_Image.H : Aucun fichier ou dossier de ce type
48 | #include <FL/Fl_Tiled_Image.H>
| ^~~~~~~~~~~~~~~~~~~~~
compilation terminée.
make[2]: *** [src/CMakeFiles/rakarrack-plus.dir/build.make:76: src/CMakeFiles/rakarrack-plus.dir/Config_fltk.C.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:295: src/CMakeFiles/rakarrack-plus.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
But it work fine with cmake -DBuildRakarrackPlus=OFF ..
. Thanks.
That is strange... Just to confirm, your Gentoo distribution has the Fl_Tiled_Image.H file in the FLTK include directory: On Manjaro and Ubuntu FLTK it is located in /usr/include/FL/. Not sure where FLTK is installed on Gentoo.
The error is saying that the Fl_Tiled_Image.H file cannot be found. Unless there is some error in the FLTK installation, I do not know what else could be the problem.
The reason the LV2 only now builds is because I removed the FLTK includes which were not needed for LV2s.
$ locate Fl_Tiled_Image.H
/usr/include/fltk/FL/Fl_Tiled_Image.H
/usr/include/ntk/FL/Fl_Tiled_Image.H
If I take a look at the fltk files list, all include files are in /usr/include/fltk/FL/, which imply the fltk base include dir is not /usr/include but /usr/include/fltk, it is a symlink /usr/include/fltk/Fl -> FL, the .so files are into /usr/lib64/fltk/, the executables in /usr/bin, and it is /usr/share/cmake/Modules/FLTK-Functions.cmake
Well, if it is an issue specific to gentoo, I can try to make a gentoo specific patch for it.
BTW, in the meantime, I have done a rakarrack-plus ebuild in order to be able to use portage to install that great software. I will publish it into an overlay and at the gentoo bugzilla when that issue will be solved. When taking a look inside CMakeLists.txt, it is a python3 check if I understand well. Is it a build time dependency or, as I think, a run time depend?
It work now. And no patch is needed, it is a variable in src/CMakeLists.txt:
cmake -DFLTK_INCLUDE_DIRS:PATH=/usr/include/fltk ..
I have to try it on master and 1.2.3, and I will report later how it worked.
The patch You committed for lv2 is needed. But 1.2.3 and master are building fine with
-DFLTK_INCLUDE_DIRS:PATH=/usr/include/fltk -DBuildLV2Plugins=OFF
Thanks.
The python3 is a build dependency, but only if you are building the carla presets. Your original post indicated that carla presets were not being build, and the presets are not build by default. Python3 is not a runtime dependency.
Interesting, your original post showed:
FLTK_INCLUDE_DIR:PATH=/usr/include/fltk
And your cmake that works:
FLTK_INCLUDE_DIRS:PATH=/usr/include/fltk
The only difference being:
DIR vs DIRS
Looks like some sort of Gentoo specific issue regarding how the fltk library is packaged and cmake???
I will be putting out another micro release soon, and push the patch to master as it was valid regardless of the build failure.
Thanks for reporting the issue.
A typo I guess... And you are welcome. You and your team did a very good job with that software. I just try it a few minutes, and it works great.
It appears that the typo may be on my part. I sent another patch to wip branch with a fix to the CmakeLists.txt. This might allow you to compile without the need to manually set the FLTK_INCLUDE_DIRS variable.
Yep, with your last push, the FLTK_INCLUDE_DIRS variable is not needed anymore here.
Great. Thanks for confirming and helping to track this down. Just pushed this and 1.2.4 to main.
Great and Thanks for the good work.
Which mean fatal error: FL/Fl_Tiled_Image.H : No file or directory of that type That is on a gentoo linux amd64 system with fltk-1.3.5 and cmake 3.27.3.
This append both with the git code and with 1.2.3.
FLTK_INCLUDE_DIR is correct and the missing file exist. Is it something I can do about this?