SteamDeckHomebrew / decky-loader

A plugin loader for the Steam Deck.
https://decky.xyz
GNU General Public License v2.0
4.69k stars 163 forks source link

[Request] Use the new installer in the readme instructions #321

Closed PartyWumpus closed 1 year ago

PartyWumpus commented 1 year ago

Please confirm

Feature Request Description

The new GUI installer should probably be listed in the readme because it'll be easier for users etc (also otherwise I wasted a weekend making it :p) The fewer steps in the download process, the better. If possible, a big download button that sends them straight to the .desktop that they can then just run and have work would be amazing. (also, the old installers should probably still be mentioned somewhere in the readme for users who want a fast install)

Further Description

There seems to be a few ways of having a download button (and they're all not great imo):

  1. Download button that sends users to a github pages site (or a different site i guess) that links the user to the most recent version of the file. An example that uses this is Viper. This, and the second option, have to have the .desktop file in releases as github doesn't seem to let you download other files via a browser.

  2. Download button sends that users directly to the most recent version of the file and this action will update the readme every time there's a release

  3. Download button uses DownGit with a link like this to download it. I don't love this idea, but anyway it appears it downloads every file as a .zip (for now) so isn't viable.

Without a button:

  1. Put the installer in releases and just ask people to go there and use it

  2. Ask people to run curl -L ... | sh like before. This is not a good solution and is also not really compatible with adding signed releases later... Also the main goal of the installer is stopping people from having to use the terminal, so that would somewhat defeat the point.

I'm sure there's some other options (probably something obvious), but I just wanted to make this issue to actually get the ball rolling on using the new installer. With all these options I'm not going to start making a PR for it without some input. (But I am happy to do it myself if possible)

PartyWumpus commented 1 year ago

for more context on how Viper does it, check their index.html and main.js. (their download button links to the index.html file)

PartyWumpus commented 1 year ago

phew there is an easier way. Add the .desktop file to releases, and then have a button with a link to https://github.com/SteamDeckHomebrew/decky-loader/releases/latest/download/decky_installer.desktop Will work on pr shortly. Not sure how I missed this one.