Last line of diff improperly highlighted as added

SteamedPears / CodeReviewClientMaster

Other

4 stars 3 forks source link

Last line of diff improperly highlighted as added #52

Closed spratt closed 12 years ago

spratt commented 12 years ago

Look at line 116/117: http://review.steamedpears.com/view.html?id=1f9846bf-5755-4e28-8674-d14475c353c6 for an example.

Gankra commented 12 years ago

The google diff library seems super fucked. Perhaps I just misused it, but it seems messed up. I suggest considering an alternative. One which works by lines, preferably.

cdelahousse commented 12 years ago

This may be fixed by getting rid of google diff. We'll solve this by finding a new diff engine.