SteamedPears / CodeReviewClientMaster

Other
4 stars 3 forks source link

0-index versus 1-index #53

Open spratt opened 12 years ago

spratt commented 12 years ago

CodeMirror stores lines in 0-index format, whereas the backend stores lines in 1-index, which leads to lots of off-by-one errors.

Gankra commented 12 years ago

I would wait on this until way have absolutely settled on continuing to use CodeMirror.

cdelahousse commented 12 years ago

We may be changing syntax highlighter. This issue depends on that change. This issue will remain open until we've resolved that issue.