search

SteffenMoritz / ridge

CRAN R Package: Ridge Regression with automatic selection of the penalty parameter
GNU General Public License v2.0
18 stars 11 forks source link

Auto-generate the NAMESPACE file #9

Closed dfrankow closed 4 years ago

dfrankow commented 4 years ago

Adds all the right directives so we can generate NAMESPACE with devtools::document(). 0 errors, 0 warnings, 0 notes.

I chose to qualify the function calls instead of import them. This turned out more invasive than I thought.

dfrankow commented 4 years ago

Also adds package-level docs (ridge.R) and removes roxygen warning about encoding.

dfrankow commented 4 years ago

I didn't test every code path changed, that would be the whole package. It would be good to have more tests.

dfrankow commented 4 years ago

Hmm, I can see the argument for using @importFrom statements instead, so the code doesn't change. Maybe I should redo. :/

dfrankow commented 4 years ago

FYI, this PR is independent of the others.

dfrankow commented 4 years ago

https://github.com/SteffenMoritz/ridge/pull/10 is the alternate method, using @importFrom. I think I like it better, so I'll close this.