SteffeyDev / react-native-popover-view

A well-tested, adaptable, lightweight <Popover> component for react-native
MIT License
615 stars 92 forks source link

Dependency Error #11

Closed rlugge closed 6 years ago

rlugge commented 6 years ago

So I just started trying to use this, and immediately got an error:

Unable to resolve ../../react-navigation/src/navigators/createKeyboardAwareNavigator" from ".//node_modules/react-native-popover-view/src/PopoverStackNavigator.js`: The module `../../react-navigation/src/navigators/createKeyboardAwareNavigator` could not be found"

Not sure what I did wrong here.

SteffeyDev commented 6 years ago

What version of react-navigation are you using?

rlugge commented 6 years ago

Looks like 1.5.12.

On Thu, Aug 9, 2018 at 3:25 PM Peter Steffey notifications@github.com wrote:

What version of react-navigation are you using?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SteffeyDev/react-native-popover-view/issues/11#issuecomment-411917542, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuiqeS86kA01sQCgOBMwGCZDl8HgWMGks5uPLbIgaJpZM4V20qa .

SteffeyDev commented 6 years ago

Ok, I officially only support version 2, and unfortunately don’t have time to do backward comparability right now with older versions. Can you upgrade to the latest version of react-navigation? I don’t know if they made any breaking changes or not.

rlugge commented 6 years ago

Ah. My understanding is they made a number of breaking changes. Sorry to have bothered you, didn't catch the dependency issue.

On Fri, Aug 10, 2018 at 5:02 AM Peter Steffey notifications@github.com wrote:

Ok, I officially only support version 2, and unfortunately don’t have time to do backward comparability right now with older versions. Can you upgrade to the latest version of react-navigation? I don’t know if they made any breaking changes or not.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SteffeyDev/react-native-popover-view/issues/11#issuecomment-412062124, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuiqZlzVmO-u6qaE7tj_IrQBOWThmZIks5uPXZOgaJpZM4V20qa .

SteffeyDev commented 6 years ago

Ok, do you have an interest in using the popover independently of react navigation? I can provide instructions to decouple it, though as long as my library detects react-navigation it will try to link it.

rlugge commented 6 years ago

Nah, thanks but I found a work-around with a different UI option. I'm just shocked this isn't a core react-native feature.

On Sat, Aug 11, 2018 at 11:05 AM Peter Steffey notifications@github.com wrote:

Ok, do you have an interest in using the popover independently of react navigation? I can provide instructions to decouple it, though as long as my library detects react-navigation it will try to link it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SteffeyDev/react-native-popover-view/issues/11#issuecomment-412291986, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuiqRyXkuTSa4A2x_l4gUaB0C_lZKw2ks5uPxzOgaJpZM4V20qa .

SteffeyDev commented 6 years ago

Ok glad you found a solution! One of the things about react native is that there is no navigation components built in, though I suppose you can count react-navigation because it is the recommended UI library. I’d love to merge this into react-navigation someday.

Anyways, is it ok if I close the issue?