Closed saiello closed 2 years ago
We need to look more to this PR but it's seem be to be a great improvement! Thanks!!!!
LGMT! Can you add some test with acl_operations
in https://github.com/StephenSorriaux/ansible-kafka-admin/blob/master/molecule/default/tests/test_acl_default.py to ensure that this won't be breaked in the future?
@ryarnyah I mean to rebase on master once the #134 will be merged to use the same testing approach used there.
@saiello In this case it might be a better idea to reuse default scenario to reuse existing tests (ACLs is supported from 0.11.0 to X and in your case it's only to ensure that it won't be breaked in the future). Furthermore we are already limited on concurrent github action that can be done so if we add another scenario we will increase drastically build time.
@saiello In this case it might be a better idea to reuse default scenario to reuse existing tests (ACLs is supported from 0.11.0 to X and in your case it's only to ensure that it won't be breaked in the future). Furthermore we are already limited on concurrent github action that can be done so if we add another scenario we will increase drastically build time.
Yes, you are right! I will add further cases to the existing tests!
I have some idea to optimize the github actions usage. I would like to work on them later. Let me know if you already have some thought about it.
@ryarnyah tests added
@saiello thank you!
Fixes #70 Fixes #124
Proposed Changes