StephenSorriaux / ansible-kafka-admin

Manage your topic's configuration (partitions, replication factor, parameters), ACLs, quotas, users and get stats, without any effort with this library. It does not use the Kafka scripts and does not require ssh connection to the remote broker.
Apache License 2.0
150 stars 46 forks source link

fix bug with change flag #151

Open owidder opened 1 year ago

owidder commented 1 year ago

Fixes #

Proposed Changes

Currently change flag in kafka_lib_topic may be set to False even though it was already set to True To fix this, let the change flag remain true by: changed = changed or len(topics_changed) > 0

-

StephenSorriaux commented 1 year ago

Thank you, looks like a good catch. Just need to check if we can add some testing around this too.

arenard commented 1 year ago

Hi Stephen. Again thank you for your work on this so usefull ansible modules. Do you think about merging this fix ?