search

Sterc / modx-minify

9 stars 5 forks source link

Some SCSS Errors with Leafo's ScssPhp can be fixed #35

Closed mindeffects closed 5 years ago

mindeffects commented 6 years ago

This thread saved my life when I had trouble compiling a standard Foundation SCSS: https://github.com/leafo/scssphp/issues/446

This post (https://github.com/leafo/scssphp/issues/446#issuecomment-299485604) held the key for the solution, but it is not update save. Maybe you guys want to patch ModxMinfy a little or maybe not... 'sup to you.

Just in case someone gets strange errors from ModxMinify this here might help, so I wrote these lines. ;-)

mindeffects commented 6 years ago

I also had a problem with an empty output using MODX Minify an deadsimple SCSS like body { background: #999; }, which I could solve with the same fix:

Comment out line 3174 in core/components/modxminify/assetic/vendor/leafo/scssphp/src/Compiler.php $nextIsRoot = true; >> //$nextIsRoot = true;

Now it's running like a charme!

devlanda commented 5 years ago

I will close this issue because as it is related #41.