search

SteveDunn / Vogen

A semi-opinionated library which is a source generator and a code analyser. It Source generates Value Objects
Apache License 2.0
894 stars 46 forks source link

Added the Data property to validation so the exception thrown will co… #375

Closed sirphilliptubell closed 1 year ago

sirphilliptubell commented 1 year ago

Adding the ability to include specific validation data in the thrown exception.

sirphilliptubell commented 1 year ago

Fixed the value assignment problem and the unit tests. I left the setter on the Data property as private for now, I'm not sure that people would want to set that.

Unit tests should pass, two still failed locally but they looked like they were due to the time zone I'm in.

SteveDunn commented 1 year ago

Fixed the value assignment problem and the unit tests. I left the setter on the Data property as private for now, I'm not sure that people would want to set that.

Unit tests should pass, two still failed locally but they looked like they were due to the time zone I'm in.

Great - thanks very much for contributing! I'd really appreciate any help with the failed timezone tests - I can't get it into a state to reproduce!

sirphilliptubell commented 1 year ago

I added a fix that I think should fix the unit test that failed due to my timezone. At least it passes on my end. Thanks for updating those other verify files.

Also, is it normal that when you run build.ps1 that it takes over an hour for this to run?

Passed!  - Failed:     0, Passed:  9295, Skipped:     8, Total:  9303, Duration: 1 h 25 m - SnapshotTests.dll (net6.0)
...
Passed!  - Failed:     0, Passed:  9303, Skipped:     0, Total:  9303, Duration: 19 m 5 s - SnapshotTests.dll (net7.0)
sirphilliptubell commented 1 year ago

Thanks again for this awesome library, just found it recently and I'll definitely be using it a lot.