Fixed TBB package search to work with TBB 2021.5 (#469)

SteveMacenski / slam_toolbox

Slam Toolbox for lifelong mapping and localization in potentially massive maps with ROS

GNU Lesser General Public License v2.1

1.67k stars 525 forks source link

Fixed TBB package search to work with TBB 2021.5 (#469) #530

Closed afrixs closed 2 years ago

afrixs commented 2 years ago

Basic Info

Info	Please fill out this column
Ticket(s) this addresses	#469
Primary OS tested on	Ubuntu
Robotic platform tested on	hardware RoboTech Vision Caster

Description of contribution in a few bullet points

removed FindTBB.cmake which fails with TBB 2021.5 package present in current aptitude in Ubuntu Jammy

Description of documentation updates required from your changes

no updates required

Future work that may be required in bullet points

no future work required, awareness needed when backporting to galactic etc. - this update may need to be reverted for older systems

SteveMacenski commented 2 years ago

Tried to build this:

--- stderr: slam_toolbox                                         
/usr/bin/ld: cannot find -lTBB:tbb: No such file or directory
collect2: error: ld returned 1 exit status

Run on 22.04 / Rolling with this branch after apt update && apt upgrade.

steve@mo:~/Documents/nav2_ws$ apt-cache policy libtbb-dev
libtbb-dev:
  Installed: 2021.5.0-7ubuntu2
  Candidate: 2021.5.0-7ubuntu2
  Version table:
 *** 2021.5.0-7ubuntu2 500
        500 http://us.archive.ubuntu.com/ubuntu jammy/universe amd64 Packages
        100 /var/lib/dpkg/status

afrixs commented 2 years ago

I'm sorry, I committed from a different machine than where I had tested the patch, and of course, I made a typo (two colons were needed, TBB::tbb). However, I'm completely removing the tbb dependency from ceres_solver_plugin since it is unused.

SteveMacenski commented 2 years ago

Thanks!