search

StevenLooman / async_upnp_client

Async UPnP Client for Python
Other
46 stars 37 forks source link

Features and BugFixes #201

Closed helviojunior closed 2 months ago

helviojunior commented 1 year ago

New Features:

BugFix:

helviojunior commented 1 year ago

Adjusted.

StevenLooman commented 1 year ago

Thank you for this PR! Looks mostly good to me, just one change request and question.

helviojunior commented 1 year ago

Thank you for this PR! Looks mostly good to me, just one change request and question.

Do you want that i change the XML parse of code?

StevenLooman commented 1 year ago

Do you want that i change the XML parse of code?

What would the change be? I'd rather stick to the general idea of that table: out is used to serialize the value/coerce the value to a string.

I can see things not working out properly though. Some devices might want an escaped XML-string, while others want inline XML. (Whether the first or the latter is the valid option is a different discussion. I just know there are lots of different implementations out there. 😄)

Also, there is no XML datatype in https://openconnectivity.org/upnp-specs/UPnP-arch-DeviceArchitecture-v2.0-20200417.pdf. I'd like to stick to the standard as much as possible. Perhaps you can use a string datatype and serialize/deserialize yourself? Or include a monkey patch in the specific server to fiddle in the XML datatype?

StevenLooman commented 2 months ago

I am closing this PR. Fixes have been added via #243 #242.

Any "fixes" regarding communication can be handled via hooks from #233.