StevenLooman / async_upnp_client

Async UPnP Client for Python
Other
46 stars 37 forks source link

Incorrect types in IgdDevice.async_(add/delete)_port_mapping #208

Closed JurgenR closed 1 year ago

JurgenR commented 1 year ago

In IgdDevice.async_add_port_mapping and IgdDevice.async_delete_port_mapping the types for remote_host and lease_duration do not allow for a None value despite handling them:

https://github.com/StevenLooman/async_upnp_client/blob/e05dae4d293b28da6e3bff759046c9c316321d7e/async_upnp_client/profiles/igd.py#L383

StevenLooman commented 1 year ago

Thank you for this issue @JurgenR. You are right, the handling of None values can be removed, as this will never happen. I'll remove these.

StevenLooman commented 1 year ago

Thanks! This will be included in the next release.