search

StingraySoftware / stingray

Anything can happen in the next half hour (including spectral timing made easy)!
https://stingray.science/stingray
MIT License
166 stars 137 forks source link

Check that all notebooks run with the latest version of the code #802

Open matteobachetti opened 4 months ago

matteobachetti commented 4 months ago

As the title says.

AnonymousCodes911 commented 4 months ago

Greetings @matteobachetti, While checking the notebooks, i found an import error(?) and raised a PR please verify it and let me know if we have to find similar errors and raise PR accordingly. Edit: Fixed nearly all the Notebooks and help needed to replicate files used in some of the Notebooks, refer commits Thankyou

kartikmandar commented 4 months ago

Hello @matteobachetti , I was going through the notebooks. Are only problems associated with the code are to be considered for a request or something as trivial as a spelling mistake should also be considered?

matteobachetti commented 4 months ago

@kartikmandar spelling mistakes surely need to be fixed. Please try to reduce the changes to the bare minimum (e.g. do not re-run full notebooks for changes to the Markdown text)

kartikmandar commented 4 months ago

Sure @matteobachetti I will keep that in mind.

kartikmandar commented 4 months ago

Hello @matteobachetti I checked all the notebooks extensively and apart from the issues AnonymousCodes911 and I solved, everything was working fine. Also there still some warning messages to solve in LombScargle notebook and some issues in Pulsar notebook.