StoDevX / AAO-React-Native

The St. Olaf community, now in pocket size.
GNU Affero General Public License v3.0
42 stars 16 forks source link

Add Offices to hours view #544

Closed hawkrives closed 7 years ago

hawkrives commented 7 years ago

Probably should, since we've got literally every room around it listed.

What category should it go in?

name: Center for Multicultural Engagement
abbreviation: CMIE
category: Offices

schedule:
  - title: Hours
    hours: 
      - {days: [Mo, Tu, We, Th], from: '8:00am', to: '8:00pm'}
      - {days: [Fr], from: '8:00am', to: '5:00pm'}

breakSchedule:
  fall: []
  thanksgiving: []
  winter: []
  interim: []
  spring: []
  easter: []
  summer: []
drewvolz commented 7 years ago

I think it might be the Center for Multicultural and International Engagement

drewvolz commented 7 years ago

I could be wrong. Maybe it is the International Student Life office?

hawkrives commented 7 years ago

Second one, yeah.

hawkrives commented 7 years ago

That is one outdated floorplan, buntrock

hawkrives commented 7 years ago

It might be the CMIE too.

elijahverdoorn commented 7 years ago

I propose adding an "Office" category with some of the following:

[edit(hawken): moved to OP]

I might have missed some, anyone have suggestions?

EDIT: Making this the list of offices to add. Feel free to add to the list as you think of things. Not all of these will go under the "offices" category.

drewvolz commented 7 years ago

Telecom, Parking, Admissions, Piper Center, Bon App office... to name a few.

hawkrives commented 7 years ago

Helpdesk is already in the hours list

hawkrives commented 7 years ago

From Bidit:

8am-8pm on Monday-Thursday, 8am-5pm on Friday and closed on Saturday and Sunday.

It's a pretty popular hangout for international students. So might be worth it.

It's a student lounge for everyone, some choose to go and some don't, so I wouldn't expect any social effect.

hawkrives commented 7 years ago

Alright. So, assuming we want the offices category, where do we want that in the sort order?

Currently:

  1. Food (4)
  2. Supplies and Books (2)
  3. Mail and Packages (2)
  4. Libraries (4)
  5. Help and Support (4)
  6. Gym (5)
  7. Health and Wellness (3)
  8. Acadamia (8)

edit: added section lengths

drewvolz commented 7 years ago

Either above or below academia? What are thoughts about moving academia upwards?

hawkrives commented 7 years ago

Academia's really long already… I added section length to the above comment.

drewvolz commented 7 years ago

We don't know what buildings are important to people, I guess. Length isn't an issue to me.

hawkrives commented 7 years ago

Yeah, let's put "offices" after Academia. It's not that long on a screen.

hawkrives commented 7 years ago

@ekmanzu, @elijahverdoorn, @zimmer18 anyone want this?

elijahverdoorn commented 7 years ago

I'm going to focus on getting this release done, but I'd encourage @zimmer18 or @ekmanzu to take a look!

zimmer18 commented 7 years ago

Added Registrar to list of offices.

zimmer18 commented 7 years ago

Found hours for the below offices:

and will add these to the building hours

hawkrives commented 7 years ago

I added a checklist to the OP and am checking them off from your list, @zimmer18, so we know what we still need to look for.

EDIT: Done checking things off.

hawkrives commented 7 years ago

Oh, one note @zimmer18 (and @ekmanzu, @elijahverdoorn): you'll notice the numeric prefixes on the building hours files?

That's because the output JSON array is sorted alphabetically by the filename. The first number controls the "group"'s position in the array (making Food go first, for example); the second number is optional, and is only needed if you don't want alphabetical order for that section; as such, Academia is alphabetical, but Food is manually sorted so that the Bag Lunch Line is at the bottom, not the top, of the list.

For Offices, I think we'd be fine with alphabetical ordering? So, you can just name the files, like, 9-office-of-student-activities.yaml.

hawkrives commented 7 years ago

I'm in Slack if you need any help with the data stuff.

hawkrives commented 7 years ago

Also, followup question: do we want to pull the Helpdesk into Offices? It's already listed, under Help and Support.

zimmer18 commented 7 years ago

I saw the numbering for the other hours and that all makes sense. Yes I think it makes the most sense for the offices to be organized alphabetically so I'm not adding the second number. I think the Helpdesk should stay where it already is because it makes more sense to look for it under Help and Support than Offices.

hawkrives commented 7 years ago

Moved to #612 for the remaining offices