StrangeLoopGames / EcoIssues

131 stars 21 forks source link

[0.9.3.1] Number formatting should follow user's computer format #21460

Open ThePiachu opened 3 years ago

ThePiachu commented 3 years ago

Today on White Tiger a good deal of people were panicking after seeing messages like

image

"Oh no, I owe $40k, but I only have $100!", etc. While in reality, it's $40, rather than 40k due to the difference in european and american number formatting.

In general, the game should either support multiple decimal point formats (https://en.wikipedia.org/wiki/Decimal_separator) through some setting menu, or perhaps use whatever the system is using to avoid confusion. Probably the same would have to be done for date format anyway, especially if #19266 will get implemented.

ThePiachu commented 3 years ago

Moreover, this formatting isn't consistent with formatting in the stores and economy viewer:

image

ThePiachu commented 3 years ago

When you hover over your skills and see your total XP, it's also displayed with a ",", and the number could really use some way of deliniating where the thousands are. I guess it might be prudent to have some global number formatter to keep things consistent across all number displays.