search

Stranger6667 / postmarker

Python client library for Postmark API
https://postmarker.readthedocs.io/en/stable/
MIT License
134 stars 29 forks source link

send_with_template won't allow alias #179

Closed 2x2xplz closed 3 years ago

2x2xplz commented 5 years ago

Referring to #150

When I try to send an email using a template alias, postmark.emails.send_with_template(TemplateAlias=alias, TemplateModel=model, To=sendto, From=efrom)

I get the following response: TypeError: send_with_template() missing 1 required positional argument: 'TemplateId'

Thanks.

viperfx commented 5 years ago

@Stranger6667 I am facing this issue too.

From the Postmark API specs - https://postmarkapp.com/developer/api/templates-api#email-with-template

TemplateAlias - The alias of a template to use when sending this message. Required if TemplateID is not specified. TemplateId - The template to use when sending this message. Required if TemplateAlias is not specified.

So TemplateID should not be required, if TemplateAlias is specified

MrLightful commented 3 years ago

@Stranger6667 any updates on this one?

Stranger6667 commented 3 years ago

Hi @romatallinn

Sorry, I completely missed this issue; I will put it on my TODO list for the next week. Thank you for pinging me

Stranger6667 commented 3 years ago

The fix is released in 0.17.0 (it also drops support for Python 3.5).