Bug: `host_map_mount_order_detection` sets the wrong asset order.

[Badpoolinator]

Describe the bug

Using the command: host_map_mount_order_detection 1 will actually set the wrong asset priority. I used this in P2:CE with Portal 1's maps, and it used the wrong assets order.

I changed the priority in gameinfo.txt to make Portal 1's assets the highest priority, and it still didn't work. Once I disabled the command and restarted the map, the assets set correctly.

To Reproduce

1. Mount a game's assets (I am using Portal 1 for example.)
2. Run the command: host_map_mount_order_detection 1
3. Run a Portal 1 map.

Issue Map

Any Portal 1 map.

Expected Behavior

The asset order should be corrected to have Portal 1 at highest priority.

Operating System

Windows 11

[TwoKrazy]

this is more or less intended behavior, as far as I can tell. According to @SCell555, the convar works by detecting what assets are used the most in any given map. The problem occurs because many assets are shared between Portal 1 and 2, causing the game to detect Portal 2 when the map uses mostly assets that happen to be in both games. Apparently, they made the system to fix HL2 assets overriding TF2 ones, and that system works for that purpose since TF2 has a lot of exclusive assets that aren't shared with HL2.

[TwoKrazy]

Although, I agree, it's not really a foolproof solution because of the shared assets thing

[Badpoolinator]

this is more or less intended behavior, the convar works by detecting what assets are used the most in any given map.

It does what it's coded to do, but it doesn't do what it's intended for, so I'd say this is still a bug. Shouldn't detecting what game directory it's from work? If not, a hardcoded list of maps should work fine for the most part. (Except for community-made maps.)