Streampunk / beamcoder

Node.js native bindings to FFmpeg.
GNU General Public License v3.0
399 stars 76 forks source link

Decoder hwaccel flag is too simplified #101

Open fda0 opened 2 years ago

fda0 commented 2 years ago

Recent commit 5504d7bb578363c34f436426fcef5f4e96f409a0 simplifies how hwaccel flag works. Now it is a boolean. Unfortunately this leaves less control for the end user and can lead to problems.

For example we target CUDA in our code and if we set environment variables like: DISPLAY=:0 it will assume 'vdpau' as our hardware target.

Having a possibility to specify 'cuda' manually would be less error prone for us. Simply reverting that commit would fix our issue.