Studiosity / grover

A Ruby gem to transform HTML into PDFs, PNGs or JPEGs using Google Puppeteer/Chromium
MIT License
945 stars 109 forks source link

Use puppeteer-ruby instead of puppeteer #232

Closed elondres-mim closed 8 months ago

elondres-mim commented 8 months ago

Hi! Excellent project!

I'm hesitating on using grover for one of my websites because I currently don't have nodejs installed on my server and it seems like a headache to bring in yet another language ecosystem to update and whatnot. Has any thought been put into using the puppeteer-ruby gem (https://github.com/YusukeIwaki/puppeteer-ruby) instead of the puppeteer NPM package? I think this would simplify deployment quite a bit, but I'm not sure how much effort it would be.

Thanks!

abrom commented 8 months ago

Thanks, although switching the "driver" really isn't on the cards. You are welcome to fork the grover gem and switch it yourself of course.

Note, I have spiked this concept before but the following were real blockers:

Grover is itself a pretty thin wrapper around puppeteer so a re-write of the parts needed likely wouldn't be all that complicated.