search

Study-Together-Org / time_counter

12 stars 5 forks source link

XX:YY timepoint doesnt work? #53

Closed Arianthell closed 3 years ago

Arianthell commented 3 years ago

So the am/pm timepoints show the correct daily information but it isnt the case for XX:YY time points. The text does change and shows the timepoint but the daily data doesn't show it correctly. Not sure if it is intended? If not, maybe we could implement this?

https://discord.com/channels/595999872222756885/666352633342197760/826701712593125436 It does say "Daily starts tracking at Asia/Tokyo 2021-02-01 13:00:00" but daily shows 3.7h instead of 1.6h as shows in the 2nd image. image

https://discord.com/channels/595999872222756885/666352633342197760/826701774579564544 image

Zackhardtoname commented 3 years ago

Nice found! It's not intended and seems to be a bug!

Zackhardtoname commented 3 years ago

Apparently the dateparser library we use couldn't handle formats like "13:00".

We should have never bothered with that external lib for this to begin with but oh well, users don't need that format anyway since we are only doing hours.