Build .mo files before sdist/build_py

[Stunkymonkey]

when I look at the file produced by the CI, the locale folder is missing. I guess you would have to adjust the CI?

[lvxnull]

I ran the same command as the CI locally and the archive had the locale directory

[Stunkymonkey]

Hmm referring to this file: https://github.com/Stunkymonkey/nautilus-open-any-terminal/actions/runs/7372377291/artifacts/1141238972

[lvxnull]

I did some further testing and this happens only when the .mo files aren't present before running the build command. python -m build seems to run build_py too late to actually capture the newly-created .mo files. I'll see if I can get it to make .mo files before sdist instead.

[lvxnull]

I have no idea how to get setuptools to do the right thing when compiling .mo files with a build step for both python -m build and pip install .. I reverted to previous, eager compilation instead, but I kept the MO_FILES glob pattern.

[Stunkymonkey]

now it looks like before.

Should we change the commands in the CI to get your previous solution working?

[lvxnull]

I managed to get it to work by hooking two different commands at once. As a side note, I hate that pylint requires docstrings for every class/method/function, even when they don't add any new information besides what's in the name/arguments

[Stunkymonkey]

I managed to get it to work by hooking two different commands at once. As a side note, I hate that pylint requires docstrings for every class/method/function, even when they don't add any new information besides what's in the name/arguments

I am fine with disabling this. you can do this in the pyproject.toml