search

Stunkymonkey / nautilus-open-any-terminal

GNU General Public License v3.0
536 stars 54 forks source link

Fix "open in wezterm" #114

Closed flexagoon closed 7 months ago

flexagoon commented 8 months ago

The "Open Wez's Terminal Emulator Here" button always opens Wezterm in the ~ directory. This PR fixes it by applying the same workaround that is used for BlackBox.

lvxnull commented 8 months ago

That's weird, I cannot reproduce this issue. I tested both flatpak and appimage versions of wezterm and they seemed to work fine.

flexagoon commented 8 months ago

@lvxnull oh, turns out the issue only happens to me because I revoked filesystem=home access to the Wezterm Flatpak. In that case I'm not sure if this is something that should be fixed here or no. It seems like every feature of Wezterm except for launching it with --cwd . works fine without that permission.

Stunkymonkey commented 7 months ago

so how do we continue here? I am planing to make a release in the next weeks.

lvxnull commented 7 months ago

i dont like the idea of adding another edge case. I'd rather either keep the code as is(it works under default flatpak permissions) and maybe mention this in the readme, or just always pass the path on the command line, but that could be more error prone

flexagoon commented 7 months ago

In this case I'll probably close this. I don't think there are that many people who specifically use Flatpak wezterm with non-default permissions, so adding a note to readme will just complicate it unnecessarily. If this happens to someone else, you could just point them towards this PR.