search

Su5eD / IC2-Patcher

A tool to modify IndustrialCraft2 using binary patches
The Unlicense
8 stars 4 forks source link

[bug] Kinetic Generator #11

Open Romz24 opened 1 year ago

Romz24 commented 1 year ago

Describe the bug Pull request bug - https://github.com/Su5eD/IC2-Patcher/pull/9

After this change, my kinetic generator connected to the kinetic wind generator starts generating energy even without rotors. It's enough to re-enter the chunk and this bug appears.

This should be fixed before the release, as it seriously disrupts the game's economy and results in energy duplication.

Additional context image image

Rolling back this change solves the issue, energy stops being generated without rotors.

Su5eD commented 1 year ago

@ThePixelbrain any idea why resetting world data could cause this?

ThePixelbrain commented 1 year ago

IC2s Wind Simulation is being created with the world data. I don’t understand how this issue happens though. Will look into it.

ThePixelbrain commented 1 year ago

Sorry for the delay, I finally took a look at this.

I wasn't able to recreate the issue in my test instance (Just latest IC2, IC2Patcher and JEI). Could you tell me more about your environment? What version of IC2 are you using? What Forge version? Etc.

Romz24 commented 1 year ago

Forge - 14.23.5.2860 IC2 - 2.8.222 IC2-Patcher - Compiled from latest sources

I'm using a dedicated server, maybe this bug only occurs on a dedicated server and won't work in singleplayer.

ThePixelbrain commented 1 year ago

I still wasn't able to recreate this on a dedicated server. You could confirm that it happens in an instance with just IC2 and IC2 Patcher installed? Also there is a precompiled version including the energy net patch on Curseforge. You might wanna test with that one as well, though I don't really see how building it yourself could have caused this.

Romz24 commented 1 year ago

Not only do I have IC2 and IC2-Parcher installed, I also have a bunch of other mods. But the problem occurs only after this change, when I rolled it back the problem disappeared.