Adding File to SitePage Lib using AddModuleFile - Save Conflict Error

[MaximilianBerg]

Hi,

I was trying to add an aspx file to the SitePages library on a SP 2016 Site. Every time i was activating the SharePoint feature, which should add the file to the library, i got a save conflict error. So I built a custom solution, whose only task was to provide this file. I activated the feature on a new, empty and english sitecollection.

After I got the error message, I checked the site and the library AND the file are available. Nevertheless I got this error the feature activation failed.

I'm using the SPMeta2 Core and SSOM Foundation Version: 1.2.130 with the following Code.

var ssomProvisionService = new SSOMProvisionService();
var currentSite = (SPSite)properties.Feature.Parent;
Homepage.Content = Resource.Homepage;

var gobSiteModel = SPMeta2Model.NewSiteModel(site =>
    site
        .AddSiteFeature(BuiltInSiteFeatures.SharePointServerPublishingInfrastructure.Enable())
);

ssomProvisionService.DeploySiteModelIncrementally(currentSite, gobSiteModel, nameof(gobSiteModel));

var gobWebModel = SPMeta2Model.NewWebModel(web =>
    web
        .AddList(BuiltInListDefinitions.SitePages, list =>
                list.AddModuleFile(Homepage)
        )
);

ssomProvisionService.DeployWebModelIncrementally(currentSite.RootWeb, gobWebModel, nameof(gobWebModel));

ModuleFileDefinition Homepage = new ModuleFileDefinition
{
    FileName = "Homepage.aspx",
    Overwrite = true,
};

Thanks.

Greeting Max

[SubPointSupport]

Alright, let us check this one on SharePoint 2013/2016.

[SubPointSupport]

Every time i was activating the SharePoint feature, which should add the file to the library, i got a save conflict error. Could you please share your exception? Is it an exception on page creation/saving or exception on SPWeb.Update() method call?

Here is what we think is happening: within a feature activation event the code tries to do several things:

• activate SharePointServerPublishingInfrastructure feature
• provision artefacts
• save state of the provisioning artefacts as we use DeployWebModelIncrementally() method

All these things are already happening within feature activation event. During the current feature activation, enabling SharePointServerPublishingInfrastructure feature would trigger another SPWeb update methods, then comes back to the original feature activation, creates artefacts and .DeployWebModelIncrementally() calls another SPWeb.Update() method while saving the model state.

What we aren't sure is that where exactly the issue is happening:

• is it during the SPWeb.Update() calls
• or is it during the page creation/saving update call

To solve this, a few things can be recommended:

• excluding feature activation within the current feature; move it away, don't activate feature programmatically, put a feature dependency in your feature definition requiring people activate publishing infrastructure BEFORE your feature
• test your feature again, most likely it would be all good
• if it still not good (which we seriously doubt it be), try to use .DeployWebModel() method instead of .DeployWebModelIncrementally(). It might be we cause of the issue but we bet 99% on it's not and you'll be fine once removing programmatic feature activation

Let us know how it goes and if there is anything else we can help you with. We'll keep this issue open until we find a solution together.

[SubPointSupport]

cc @MaximilianBerg

[MaximilianBerg]

Hi,

thanks for the response.

I will give it a try and let you know about the results.

Greetings Max

[SubPointSupport]

Nice! Looking forward to hearing from you soon.