SuffolkLITLab / docassemble-AssemblyLine

Quickly go from a paper court form to a runnable, guided, step-by-step web application powered by Docassemble. Swap out branding and pre-built questions to meet your needs.
https://suffolklitlab.org/docassemble-AssemblyLine-documentation/
MIT License
41 stars 5 forks source link

versions after 2.22.2 don't seem to work with my save and load answers #850

Open ladracer opened 5 months ago

ladracer commented 5 months ago

Describe the bug When using any version of the AssemblyLine after v. 2.22.2 (2.22.2 works well) causes the program to timeout and crash the server....when a user saves or loads an answer set. Sometimes answer sets can be saved, but never can they be loaded without crashing the server. Quinten thought it might be tied to sql objects in my interviews like judges and db_attorneys. Removing those from the saved answers did not seem to matter.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Version Information (should be in your.docassemble.server/updatepackage:

Additional context Add any other context about the problem here.

ladracer commented 5 months ago

If I try to upgrade ALDocument past 2.22.2 then the program loads but will not complete the task of assembling a document, as it times out and crashes the server (locking it up so you can't SSH in to the container) and have to do a container (not just the docker container but the entire AWS instance) shutdown and restart if you don't kill the program almost immediately.

Nonprofittechy Wrote Notes:

Is this due to a problem with saving or loading a snapshot? [Timing isn't clear]
Michael reports it happens even with the background processing of the document in place, so it's not just slow, it might be an infinite loop?
We couldn't spot any changes in 2.22.2 to 2.23.0 or 2.24.0 that would explain slower document assembly or add a potential for an infinite loop
ladracer commented 5 months ago

Nonprofittechy wrote "Great, I guess we know it's something to do with the specific variables that are being saved. Just a thought: perhaps it's a problem with saving the SQL Objects, like judge, etc?"

ladracer commented 5 months ago

by adding "judge" to the excluded list of variables, I was able to get it to save an answer set without crashing or hanging. However, attempting to load that newly saved answer set still caused the program to hang indefinitely. NOTE that I also chose to not have an attorney on the other side (other_parties[0].attorney) to simplify the test....so no FloridaAttorney was present in the test variables saved.