search

SumoLogic / sumologic-java-http-core

Core Java components for sending data to Sumo Logic HTTP sources
Apache License 2.0
2 stars 4 forks source link

Unnecessary String formatting #12

Open ruslan-belinskyy opened 4 years ago

ruslan-belinskyy commented 4 years ago

Here: https://github.com/SumoLogic/sumologic-java-http-core/blob/a482443a7f7bb7bf0beeb99e39b19308d850e496/src/main/java/com/sumologic/http/aggregation/BufferFlushingTask.java#L57-L60 String formatting is done for log in Debug level. This log most likely will never be logged in Production but so many objects involved in formatting that String. If you don't want to move to SLF4j, can you at least check if isDebugEnabled() before doing formatting.

mccartney commented 1 year ago

If you don't want to move to SLF4j

Just commenting on this part. This project has moved to slf4j since that comment had been made.