search

SumoLogic / sumologic-net-appenders

Several appenders for .NET developers to use that send logs straight to SumoLogic.
Apache License 2.0
23 stars 39 forks source link

Srclink #58

Closed TerribleDev closed 5 years ago

TerribleDev commented 7 years ago

Source link is a technology added to roslyn, along with a project to auto generate the files for roslyn. In short source link is a json file with urls to the source files of a project. That file is passed into roslyn as part of compilation.

The source link command line project auto generates these files based on the shaid of the current git commit, and dynamically builds links to github/bitbucket/gitlab/etc.

In visual studio 2017, with sourcelink enabled, and debugging 'just my code' disabled. You should be able to step into these functions during interactive debugging.

srclink

TerribleDev commented 5 years ago

I know this was a year old but don't you think source linking is worth exploring?

bin3377 commented 5 years ago

well. I agree it's a good technology. but I'm not sure if it's compatible with .NET core developing env. and on the other side, since this is fully open sourced project, including .pdb in package is not such beneficial (since you can have full source access when debugging if necessary)

TerribleDev commented 5 years ago

dotnet core uses the portable PDB format which is supported

Have you tried debugging a public package? You don't just step in and have it work, you have to download the source code to disk, its infuriating to do it over and over again.

bin3377 commented 5 years ago

okay... it's better to have feature and the framework itself is in preview. so we probably not so aggressive to absorb it now.

On the other side, I personally don't like the idea locking source code down to a 3rd party infrastructure (here is the symbol server provided by Microsoft), which may cause unnecessary bug, outage, etc.

TerribleDev commented 5 years ago

I think you are conflating the sourcelink msbuild infrastructure with the actual feature. The roslyn feature has not been in preview for some time, its been around since VS2015. Using the raw feature however is hard which is why the msbuild tasks are around.

Yes the sourcelink msbuild implementation from the dotnet foundation is in preview, and will be for some time. This PR used ctaggart's implementation that was not in preview.

Not in preview for roslyn Not in preview for ctaggart's msbuild implementation