SunstriderEmu / BugTracker

Endless.gg bugtracker
https://endless.gg
30 stars 25 forks source link

Low priority: Floating Combat Text not displaying the auto-attack that kills the target / some extra attacks / bonus damage instances #5672

Open Dalzedur opened 6 months ago

Dalzedur commented 6 months ago

Describe the bug Floating Combat Text is wonky at times and doesn't show everything it should, even if those options are ticked. I'm not sure what all those cases are specifically, but on paladin when I have reckoning / flurry axe (possibly thrash blade as well) proc an extra hit, those extra hits often seem to not generate a floating combat text in some capacity. The expectation is that if you have seal of righteousness active and you have reckoning on, you should get two white spams and two yellow spams for landing a hit, but that doesn't seem to happen to me. Also, when you land a white auto-attack on an enemy which deals enough damage to kill it, that doesn't generate a floating combat text, the target just dies with no floating damage number. Battle log does record everything, so you can see them there. Now, this has basically zero gameplay impact, other than making it harder for the player to keep track of everything and can cause delays in reacting to stuff, maybe, so it's not a high priority to get fixed if you have better things to do.

Character name Dalzedur

To Reproduce

  1. Enable floating combat text in options - interface - combat text, tick options on
  2. Attack stuff, observe floating combat texts that you get and compare them to what is shown in battle log
  3. Notice that some texts are not generated

Reckoning final effect: https://www.wowhead.com/tbc/spell=32746/reckoning Reckoning buff effect: https://www.wowhead.com/tbc/spell=20178/reckoning Reckoning talent: https://www.wowhead.com/tbc/spell=20182/reckoning Flurry axe: https://www.wowhead.com/tbc/item=871/flurry-axe Flurry axe proc: https://www.wowhead.com/tbc/spell=18797/flurry-axe Thrash blade: https://www.wowhead.com/tbc/item=17705/thrash-blade Thrash blade proc: https://www.wowhead.com/tbc/spell=21919/thrash

Expected behavior Sometimes on official, when you are doing a lot of instances of damage at almost simultaneously, there are so many floating combat numbers visible at the same time that it starts to organize themselves on the screen in like a honey comb pattern. Best seen when dealing aoe damage to oversized groups via spells or Ravager axe. While it can be distracting to have them spam on the screen like that, there is some satisfaction to be gained when observing it. But on this codebase, it seems like the floating combat text is not as spammy, so I'm not sure if it's working as intended to reduce that spam, or if there are just cases where it doesn't get generated as it should.