SuperTux 0.3.5a fails to parse repository file index-0_4_0.nfo

SuperTux / addons

10 stars 18 forks source link

SuperTux 0.3.5a fails to parse repository file index-0_4_0.nfo #13

Open Grumbel opened 8 years ago

Grumbel commented 8 years ago

 [WARNING] /build/supertux-f3Xlnc/supertux-0.3.5a/src/addon/downloader.cpp:354 Exception in Downloader: Problem when reading Add-on list: Problem when parsing addoninfo: not a valid Addon::Type: languagepack

SuperTux 0.3.5a is the version shipped with Ubuntu15.10

brmbrmcar commented 8 years ago

Why is it getting it from there instead of index-0_3_5.nfo?

LMH0013 commented 8 years ago

My guess is because after the 0.3.5 release, the index was changed to 0.4.0 in anticipation of the next release. Nobody caught and reversed it for 0.3.5a.

tobbi commented 8 years ago

That's exactly what happened.

maxteufel commented 8 years ago

That's what I was saying as well, as such this is an issue for the distro package managers, who should patch this in their releases. We can't magically change the 0.3.5a release anymore.

Grumbel commented 8 years ago

The distro maintainers can't do much, as they don't have a correct .nfo to point to. It would also be a waste of time to fix 0.3.5a when they could just update to 0.4.0 instead.

Possible solutions: Remove language packs from 0.4.0.nfo, put them in 0.4.1.nfo, update 0.4.1 to point to new .nfo, breaks language packs in 0.4.0 obviously, but fixes 0.3.5a.

Alternative solution: Forget about 0.3.5a, was a dev-snapshot anyway and just redirect users to 0.4.0

For the future:

make repository_url configurable by the user (currently hardcoded)
allow more then one repository url
add a 'news box' at the start of the game that we can use to display text to the user to inform them of new releases and such

maxteufel commented 8 years ago

The distro maintainers can't do much, as they don't have a correct .nfo to point to.

I do think index-0_3_5.nfo should work with 0.3.5a.

Alternative solution: Forget about 0.3.5a, was a dev-snapshot anyway and just redirect users to 0.4.0

I like this idea, however, distros with a big userbase (Ubuntu, Fedora) packaged 0.3.5a anyway.

For the future:

make repository_url configurable by the user (currently hardcoded)

allow more then one repository url

add a 'news box' at the start of the game that we can use to display text to the user to inform them of new releases and such

:+1: