Suprcode / Zircon

Legend of Mir 3 - Official Public Zircon Source
337 stars 256 forks source link

companion issue #140

Closed trancefied closed 4 months ago

trancefied commented 6 months ago

companion randomly freeze and stops moving when it's unable to pickup an item. only happens when no boxes are ticked in companion's filter menu. providing the info (server's system logs) in photo.

1

trancefied commented 4 months ago

any leads please on how to fix it or at least have rarity types automatically enabled upon adopting a companion to stop the server from crashing? another related error that gets the server to crash:

```

at Server.Models.Monsters.Companion.FilterCompanionPicks(ItemCheck check) in C:\PATH\ServerLibrary\Models\Monsters\Companion.cs:line 505 at Server.Models.Monsters.Companion.CanGainItems(Boolean checkWeight, ItemCheck[] checks) in C:\PATH\ServerLibrary\Models\Monsters\Companion.cs:line 566 at Server.Models.MonsterObject.Drop(PlayerObject owner, Int32 players, Decimal rate) in C:\PATH\ServerLibrary\Models\MonsterObject.cs:line 2903 at Server.Models.MonsterObject.YieldReward() in C:\PATH\ServerLibrary\Models\MonsterObject.cs:line 2681 at Server.Models.MonsterObject.Die() in C:\PATH\ServerLibrary\Models\MonsterObject.cs:line 2452 at Server.Models.MapObject.ChangeHP(Int32 amount) in C:\PATH\ServerLibrary\Models\MapObject.cs:line 1285 at Server.Models.MonsterObject.Attacked(MapObject attacker, Int32 power, Element element, Boolean canReflect, Boolean ignoreShield, Boolean canCrit, Boolean canStruck) in C:\PATH\ServerLibrary\Models\MonsterObject.cs:line 2415 at Server.Models.PlayerObject.Attack(MapObject ob, List`1 types, Boolean primary, Int32 extra) in C:\PATH\ServerLibrary\Models\PlayerObject.cs:line 14154 at Server.Models.PlayerObject.ProcessAction(DelayedAction action) in C:\PATH\ServerLibrary\Models\PlayerObject.cs:line 372 at Server.Models.MapObject.StartProcess() in C:\PATH\ServerLibrary\Models\MapObject.cs:line 137 at Server.Envir.SEnvir.EnvirLoop() in C:\PATH\ServerLibrary\Envir\SEnvir.cs:line 1067

Lanaya97 commented 4 months ago

Add try catch without throwing at FilterCompanionPicks method

Suprcode commented 4 months ago

Should be fixed in latest updated