onMessage being trigged with old function reference cross-tab

[tomfa]

Bug information

The reference used to execute onMessage is the first reference of that function. I can only reproduce this with crossTab=true, and the bug only occurs in non-leader tabs.

A minimal reproducable example can be found here.

Note: you must open at least two tabs for the issue to be apparent, and it will not be present in leader tab

Affected Module

• Version: Tested 5.5.2 and 5.3 – it happens in both

Describe the bug

A clear and concise description of what the bug is.

To Reproduce

See codebox example here.

• Open the example in two tabs.
• Click the counter so value is 2 in leader tab, and 3 in second tab.
• Wait 5 seconds for timeout, in which the leader will trigger message()
• Leader tab will correctly console log that counter value is 2, but second tab will log that counter value is 1.

Expected behavior

Second tab should log updated counter value (3)

Screenshots

https://user-images.githubusercontent.com/1502702/216826601-fb1bb297-6457-410a-be98-7f104726bbbe.mov

System Information (please complete the following information)

• OS: Mac OSX 12.0.1
• Device: Macbook M1 Pro
• Browser Vendor: Chrome

Additional context

This might be the culprit of the issues #289 and #293

[SupremeTechnopriest]

Published as 5.3.3