search

Susannova / Discord_Bot

A configurable discord bot that can run on multiple servers simultaneously.
MIT License
2 stars 1 forks source link

refactor config #154

Closed NickWittig closed 3 years ago

NickWittig commented 3 years ago

A good amount of values defined in the base config are not being used by the bot anymore and should be removed.

NickWittig commented 3 years ago

https://github.com/Susannova/Discord_Bot/blob/3b6ef7f9171119ce047e31757a4cb13a0877fbe1/core/config.py#L54-L63

This function actually returns True, if the channel_id is None Was that on purpose or by mistake? If it is by mistake I suggest getting rid of this function as it can be written as a simple channel_id in valid_ids.

NickWittig commented 3 years ago

I am also not sure about the config creation wizard. Maybe that should be done in a separate file.