search

SvarDOS / edrdos

Enhanced DR-DOS kernel and command interpreter ported to JWasm and OpenWatcom C
http://svardos.org/
Other
40 stars 4 forks source link

DRBIO calculates wrong fat size for 128K clusters #9

Closed boeckmann closed 11 months ago

boeckmann commented 11 months ago

Because 128K clusters (256 sectors per cluster) are encoded as zero in the BPB field, FAT size determination fails while creating default BPB in disk.asm.

boeckmann commented 11 months ago

This seems to be is fixed by ee6356a. At least the FAT size calculation seems to work. However, when accessing such a partition, namely listing its content via DIR, the system hangs. There may also be errors in DRDOS.SYS, preventing this to work properly. This may also be of interest to @ecm-pushbx.

boeckmann commented 11 months ago

The question arises if it is wise to even create a default BPB with 128K cluster size, or to restrict this to <=64K. After fixing the remaining bugs regarding 128K clusters I tend to change the default behaviour to <= 64K for compatibility reasons.

boeckmann commented 11 months ago

As an update: free space display by DIR also hangs on smaller partitions with 64K cluster size. My next guess is that it has to do with the size of the FAT. With a 500G partition it works (FAT < 65535 sectors). With a 600G partition it breaks (FAT > 65536 sectors).

boeckmann commented 11 months ago

I close this in favour of #10, because the problem indicated by the issue title seems to be fixed by now.