Add color picker in `Filter Images` section

Swati4star / Images-to-PDF

An app to convert images to PDF file!

GNU General Public License v3.0

1.22k stars 814 forks source link

Add color picker in `Filter Images` section #573

Closed Swati4star closed 5 years ago

Swati4star commented 5 years ago

select Images to PDF
Select few images. select filter images option
select brush icon

Currently, we can select only a limited number of colors for brush.

What to do?

At the end of the color boxes that show up on selecting the brush, add an icon.
on selecting that icon, open up a color picker dialog (We already are using a color picker library in watermark section. So, use that only)

jddeep commented 5 years ago

@Swati4star I would like to work on this issue next as I resolved #571 . Do check my forked repo for the same. Kindly confirm and assign to me.

jddeep commented 5 years ago

@Swati4star then as #571 is approved by you. Please assign me this issue. I would like to work on this. Thanks

Swati4star commented 5 years ago

@jddeep please comment on one issue at a time. you have commented on https://github.com/Swati4star/Images-to-PDF/issues/574 too.

First, get started with this one.

jddeep commented 5 years ago

Okay, I will get started with this. Thanks.

jddeep commented 5 years ago

@Swati4star I have added another button for the color palette on the seekbar. Can you help a bit on how to open up the pallete which you were saying was there in the watermark section?

Swati4star commented 5 years ago

Go to view files. Select a PDF. Select add watermark option. There is a color picker in the dialog